Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LangItems::require #111648

Merged
merged 1 commit into from
May 17, 2023
Merged

Remove LangItems::require #111648

merged 1 commit into from
May 17, 2023

Conversation

Noratrieb
Copy link
Member

It's just a short wrapper used by tcx.require_lang_item. Deleting it gives us a negative diff.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2023
@rust-log-analyzer

This comment has been minimized.

@WaffleLapkin
Copy link
Member

r? WaffleLapkin
r=me with green ci

@rustbot rustbot assigned WaffleLapkin and unassigned b-naber May 16, 2023
It's just a short wrapper used by `tcx.require_lang_item`. Deleting it
gives us a negative diff.
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@compiler-errors
Copy link
Member

@bors r=WaffleLapkin

@bors
Copy link
Contributor

bors commented May 16, 2023

📌 Commit c3efa51 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
@compiler-errors
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7176db into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@Noratrieb Noratrieb deleted the language-items branch May 17, 2023 10:30
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 20, 2023
…Lapkin

Remove `LangItems::require`

It's just a short wrapper used by `tcx.require_lang_item`. Deleting it gives us a negative diff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants