Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage the interval property to precompute borrow kill points. #111759

Merged
merged 1 commit into from
May 25, 2023
Merged

Leverage the interval property to precompute borrow kill points. #111759

merged 1 commit into from
May 25, 2023

Conversation

cjgillot
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2023
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 19, 2023
@bors
Copy link
Contributor

bors commented May 19, 2023

⌛ Trying commit 340fc2d with merge 1e9133c47d2f5d7e01d94190479d872d2c4d2875...

@cjgillot cjgillot mentioned this pull request May 19, 2023
Closed
@bors
Copy link
Contributor

bors commented May 19, 2023

☀️ Try build successful - checks-actions
Build commit: 1e9133c47d2f5d7e01d94190479d872d2c4d2875 (1e9133c47d2f5d7e01d94190479d872d2c4d2875)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1e9133c47d2f5d7e01d94190479d872d2c4d2875): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.7% [-0.7%, -0.6%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.7% [-0.7%, -0.6%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 640.861s -> 640.487s (-0.06%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 19, 2023
@compiler-errors
Copy link
Member

r? compiler

@rustbot rustbot assigned b-naber and unassigned compiler-errors May 23, 2023
@b-naber
Copy link
Contributor

b-naber commented May 24, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 24, 2023

📌 Commit 340fc2d has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 24, 2023
@bors
Auto merge of rust-lang#111919 - matthiaskrgr:rollup-8qcdp0q, r=matth…
096309e 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111121 (Work around `rust-analyzer` false-positive type errors)
 - rust-lang#111759 (Leverage the interval property to precompute borrow kill points.)
 - rust-lang#111841 (Run AST validation on match guards correctly)
 - rust-lang#111862 (Split out opaque collection from from `type_of`)
 - rust-lang#111863 (Don't skip mir typeck if body has errors)
 - rust-lang#111903 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 52890cc into rust-lang:master May 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 25, 2023
@cjgillot cjgillot deleted the interval-kill branch May 25, 2023 05:27
@cjgillot cjgillot mentioned this pull request Jun 3, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2023
@Dylan-DPC
Rollup merge of rust-lang#112236 - cjgillot:interval-kill, r=davidtwco
dabcbae 
Simplify computation of killed borrows

Follow-up to rust-lang#111759

Processing the first block manually once makes the pre-order walk simpler.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 29, 2023
@Dylan-DPC
Rollup merge of #112236 - cjgillot:interval-kill, r=davidtwco
53f9af1 
Simplify computation of killed borrows

Follow-up to rust-lang/rust#111759

Processing the first block manually once makes the pre-order walk simpler.
@matthewjasper matthewjasper mentioned this pull request Jul 30, 2023
Merged
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@Dylan-DPC
Rollup merge of #112236 - cjgillot:interval-kill, r=davidtwco
da26074 
Simplify computation of killed borrows

Follow-up to rust-lang/rust#111759

Processing the first block manually once makes the pre-order walk simpler.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@Dylan-DPC
Rollup merge of #112236 - cjgillot:interval-kill, r=davidtwco
ddbc34e 
Simplify computation of killed borrows

Follow-up to rust-lang/rust#111759

Processing the first block manually once makes the pre-order walk simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-naber b-naber b-naber approved these changes

Assignees

@b-naber b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rustbot @rust-timer @bors @compiler-errors @b-naber