Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #111799

Merged
merged 117 commits into from
May 20, 2023
Merged

Update Clippy #111799

merged 117 commits into from
May 20, 2023

Conversation

flip1995
Copy link
Member

koka831 and others added 30 commits February 1, 2023 19:17
@koka831
Suggest the correct variable name for manual_let_else
a408e76
@koka831
Split if conditions by its semantics
4931f45
@koka831
Remove old feature flag in code comment
20338fd 
Since let_else feature has been stable in 1.65.0, it's now unnecessary
@koka831
Avoid renaming for TupleStruct with multiple arguments
07c8c50 
update spec

fix: move specs in fire
@J-ZhengLi
bump up regex-syntax dependency version to 0.7.0
5fc1c79
@y21
don't remove dbg! in arbitrary expressions
cc607fe
@john-h-k
wip
478555d
@john-h-k
WIP
1eff408
@john-h-k
WIP
0fb3f3b
@john-h-k
WIP
8db21e9
@john-h-k
Working
b9788fe
@jyn514
Make the BUG_REPORT_URL configurable by tools
a233bd5 
This greatly simplifies how hard it is to set a custom bug report url; previously tools had to copy
the entire hook implementation.

- Switch clippy to the new hook

  This also adds a `extra_info` callback so clippy can include its own version number, which differs
  from rustc's.

- Call `install_ice_hook` in rustfmt
@fee1-dead
initial step towards implementing C string literals
37127b8
@fee1-dead
rm diag item, use lang item
f7595e0
@john-h-k
Update trait_bounds.rs
cbd0135
@john-h-k
Update trait_bounds.rs
122793b
@alnoki
Bump README copyright
477c8b3
@fmease
IAT: Introduce AliasKind::Inherent
2bc479a
@Dylan-DPC
Rollup merge of rust-lang#108801 - fee1-dead-contrib:c-str, r=compile…
a48c735 
…r-errors

Implement RFC 3348, `c"foo"` literals

RFC: rust-lang/rfcs#3348
Tracking issue: rust-lang#105723
@flip1995
Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup
7e9abb3
@Alexendoo
Ignore expressions from macros in default_constructed_unit_structs
68eb864
@disco07
redundant_pattern_matching
afa2741
@disco07
redundant_pattern_matching
d2bbe76
@EliasHolzmann
Fix: Some suggestions generated by the option_if_let_else lint did no…
d80ca09 
…t compile
@bors
Auto merge of rust-lang#111255 - flip1995:clippyup, r=Manishearth
5889ecd 
Update Clippy

r? `@Manishearth`
@blyxyas
Minimizing changes
2a4571d
@matthiaskrgr
Rollup merge of rust-lang#110989 - jyn514:bug-report-url, r=WaffleLapkin
0b7acaa 
Make the BUG_REPORT_URL configurable by tools

This greatly simplifies how hard it is to set a custom bug report url; previously tools had to copy
the entire hook implementation.

I haven't changed clippy in case they want to make the change upstream instead of the subtree, but
I'm happy to do so here if the maintainers want - cc ````@rust-lang/clippy````

Fixes rust-lang#109486.
@cakebaker
Add missing word "are"
f4b8cb1
@disco07
fix conflict with matches macro
9e535f6
@disco07
fix conflict with matches macro
630f31c
GuillaumeGomez and others added 11 commits May 19, 2023 16:16
@GuillaumeGomez
Add new UNIQUE_CFG_CONDITION lint
ab66a86
@GuillaumeGomez
Add UI test for UNIQUE_CFG_CONDITION
fcf1948
@GuillaumeGomez
Update CHANGELOG
5328852
@GuillaumeGomez
Add check for empty cfg all condition
dbc76a7
@bors
Auto merge of rust-lang#10763 - GuillaumeGomez:unique_cfg_condition, …
940ffdf 
…r=Jarcho

Add `MINIMAL_CFG_CONDITION` lint

I encountered a few cases where some code had:

```rust
#[cfg(any(unix))]
```

In this case, the `any` is useless. This lint checks this and also for the `all` condition.

```
changelog: [`unique_cfg_condition`]: Add new `UNIQUE_CFG_CONDITION` lint
```
@bors
Auto merge of rust-lang#10795 - adrianEffe:fix/TyKind-enum, r=flip1995
28dddc7 
Update URLs in Type Checking chapter

Updated links to `Adt`, `pat_ty` and `Tykind` in the "Type Checking" chapter of the book.

### Notes:
- For discussion about the whole project, please use the tracking issue for the project rust-lang#10597  (It also contains a timeline, discussions, and more information).

changelog: Fix broken links in "Type Checking" chapter of the book
@flip1995
Merge remote-tracking branch 'upstream/master' into rustup
96b32b1
@flip1995
Bump nightly version -> 2023-05-20
2e95a4f
@bors
Auto merge of rust-lang#10802 - flip1995:rustup, r=flip1995
435a8ad 
Rustup

r? `@ghost`

changelog: none
@flip1995
Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup
12cbb6c
@flip1995
Update Cargo.lock
d780efc
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 20, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@Manishearth
Copy link
Member

@bors r+ p=1 rollup=never

@bors
Copy link
Contributor

bors commented May 20, 2023

📌 Commit d780efc has been approved by Manishearth

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2023
@bors
Copy link
Contributor

bors commented May 20, 2023

⌛ Testing commit d780efc with merge 77f4f82...

@bors
Copy link
Contributor

bors commented May 20, 2023

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 77f4f82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2023
@bors bors merged commit 77f4f82 into rust-lang:master May 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 20, 2023
This was referenced May 20, 2023
Merged
Merged
Merged
Merged
Closed
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (77f4f82): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.7% [3.7%, 3.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.7% [3.7%, 3.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.813s -> 643.563s (0.12%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.