Use ErrorGuaranteed more in MIR type ops
#111918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
custom-type-ops-err
branch
from
7f01686
to
d08b8e3
Compare
rust-cloud-vms
bot
force-pushed
the
custom-type-ops-err
branch
from
d08b8e3
to
0a35db5
Compare
|
Some changes occurred in engine.rs, potentially modifying the public API of |
|
Removed fallible, addressed nit @bors r=lcnr |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 26, 2023
…r, r=lcnr Use `ErrorGuaranteed` more in MIR type ops Delay bugs more eagerly and pass them through type op infra instead of delaying them at all the usage-sites. Follow up to: rust-lang#111741 (comment) r? `@lcnr`
This was referenced May 26, 2023
lcnr
reviewed
May 26, 2023
Comment on lines
+89
to
+94
| ( | ||
| Self::QueryResponse, | ||
| Option<Canonical<'tcx, ParamEnvAnd<'tcx, Self>>>, | ||
| PredicateObligations<'tcx>, | ||
| Certainty, | ||
| ), |
There was a problem hiding this comment.
that sure is a type xx, we should define a separate struct for that
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (be72f25): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 644.366s -> 643.81s (-0.09%) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 27, 2023
…=lcnr Perform MIR type ops locally in new solver The new solver already does caching, and it's generally more correct to be using the infcx of the MIR typeck (which has the defining anchor set correctly and has already initialized all the opaques from HIR typeck). This is based on rust-lang#111918 so look at the final 3 commits. This actually causes some tests to go from passing to failing, and failing to passing. Here's the full diff: https://www.diffchecker.com/hB4bh1A9/ Putting this up for exposure mostly. r? `@lcnr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay bugs more eagerly and pass them through type op infra instead of delaying them at all the usage-sites.
Follow up to: #111741 (comment)
r? @lcnr