Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancements on build_helper utilization and rustdoc-gui-test #112084

Merged
merged 3 commits into from
May 31, 2023
Merged

enhancements on build_helper utilization and rustdoc-gui-test #112084

merged 3 commits into from
May 31, 2023

Conversation

onur-ozkan
Copy link
Member

This change provides codebase improvements, resolves FIXME in rustdoc-gui-test and makes rustdoc-gui test able to find local node_modules directory outside of the source root.

@onur-ozkan
improve rustdoc-gui-test to find local node_modules
7105f2e 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented May 29, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 29, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 29, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

clubby789
clubby789 reviewed May 29, 2023
View reviewed changes
src/bootstrap/config.rs Outdated Show resolved Hide resolved
@onur-ozkan
create build_helper/src/util mod
2803c66 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan
use build_helper::util::try_run in rustdoc-gui-test
c64db2c 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2023
@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 30, 2023

📌 Commit c64db2c has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2023
@onur-ozkan
Copy link
Member Author

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request May 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2023
@bors
Auto merge of rust-lang#112127 - matthiaskrgr:rollup-77pt893, r=matth…
617d3d6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112031 (Migrate  `item_proc_macro` to Askama)
 - rust-lang#112053 (Remove `-Zcgu-partitioning-strategy`.)
 - rust-lang#112069 (offset_of: don't require type to be `Sized`)
 - rust-lang#112084 (enhancements on  build_helper utilization and rustdoc-gui-test)
 - rust-lang#112096 (Remove array_zip)
 - rust-lang#112108 (Fix re-export of doc hidden item inside private item not displayed)
 - rust-lang#112113 (rustdoc: simplify `clean` by removing `FnRetTy`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 183a31b into rust-lang:master May 31, 2023
@rustbot rustbot added this to the 1.72.0 milestone May 31, 2023
@onur-ozkan onur-ozkan deleted the improvements branch January 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clubby789 clubby789 clubby789 left review comments

Assignees

@clubby789 clubby789

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @rust-log-analyzer @clubby789 @bors