Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compile rustc to self-test compiletest #112256

Merged
merged 4 commits into from
Jun 11, 2023
Merged

Don't compile rustc to self-test compiletest #112256

merged 4 commits into from
Jun 11, 2023

Commits on Jun 3, 2023

  1. Don't compile rustc to self-test compiletest 

    This was changed from stage 0 to 1 in rust-lang#108905, but I'm not
sure why. Change it to `top_stage` instead to allow people to choose the stage.

This should save quite a bit of time in the `mingw-check` builder, which explicitly runs `x test --stage 0 compiletest`.
    @jyn514
    jyn514 committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    f6611d3 View commit details
    Browse the repository at this point in the history

  2. rename src/dst to original/link 

    this is consistent with std and makes it much easier to understand what's actually happening
    @jyn514
    jyn514 committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    c57eb1b View commit details
    Browse the repository at this point in the history

  3. don't return a Result from symlink_dir_force 

    this gives a more helpful backtrace if it fails

before:
```
  thread 'main' panicked at 'symlink_dir_force(&builder.config, &out, &out_dir) failed with No such file or directory (os error 2)', doc.rs:697:9
```

after:
```
thread 'main' panicked at 'symlink_dir(config, original, link) failed with No such file or directory (os error 2) ("failed to create link from /home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/doc -> /home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/compiler-doc")', doc.rs:975:5
```
    @jyn514
    jyn514 committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    3f05b1f View commit details
    Browse the repository at this point in the history

  4. fix x doc --stage 0 compiler if the compiler hasn't yet been built

    @jyn514
    jyn514 committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    d613134 View commit details
    Browse the repository at this point in the history