Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment for get_region_var_origins #112356

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix comment for get_region_var_origins #112356

merged 1 commit into from
Jun 7, 2023

Conversation

Noratrieb
Copy link
Member

#109753 changed the logic but not the comment.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2023
compiler-errors
compiler-errors approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@compiler-errors
Copy link
Member

actually wait ci shouldnt matter

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 6, 2023

📌 Commit 0e01088 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2023
@bors
Auto merge of rust-lang#112361 - matthiaskrgr:rollup-39zxrw1, r=matth…
afab366 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111250 (Add Terminator conversion from MIR to SMIR, part #2)
 - rust-lang#112310 (Add new Tier-3 targets: `loongarch64-unknown-none*`)
 - rust-lang#112334 (Add myself to highfive rotation)
 - rust-lang#112340 (remove `TyCtxt::has_error_field` helper method)
 - rust-lang#112343 (Prevent emitting `missing_docs` for `pub extern crate`)
 - rust-lang#112350 (Avoid duplicate type sanitization of local decls in borrowck)
 - rust-lang#112356 (Fix comment for `get_region_var_origins`)
 - rust-lang#112358 (Remove default visitor impl in region constraint generation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 53881f9 into rust-lang:master Jun 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Noratrieb @compiler-errors @bors @rustbot