LLVM submodule #1125
Closed
LLVM submodule #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cut out the few seconds it takes to run make install.
Seems to prevent the warning about linking bitcode with different triples.
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Add tests to associated types * Fix type mistmatch of types with projection Structures with members that had type projections in their declaration were being handled incorrectly. We were only normalizing the types when the projection was visited, which could impact on how we identify whether this structure already existed or not. This change normalizes all types before starting to codegen the entire type. Co-authored-by: Daniel Schwartz-Narbonne <danielsn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm almost ready to merge this so I'm putting it up here to give folks a chance to comment.
This series turns LLVM into a git submodule of Rust and changes the build system to completely manage the LLVM build.
The submodule lives in src/llvm and its remote is git://github.com/brson/llvm.git. Note that this is our fork of LLVM, which pcwalton will be using to do some work on stack growth. Hopefully it will be short-lived and we will switch back to the official git repo soon.
The configure script handles the calls to 'git submodule init' and 'git submodule update' and automatically reconfigures when the submodule needs to update. configure sets up LLVM build directories for every target specified, so when we cross-compile to x86_64 it will be building two LLVMs (eventually we will not want to build LLVMs for every target because we might not want - or be able - to build rustc for every target).
If you want to provide your own LLVM you can still configure with --llvm-root. We will still keep the submodule up to date, but not do the LLVM build.
I am going to try to configure the bots to not clobber the LLVM build on every checkout.