Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak spans for self arg, fix borrow suggestion for signature mismatch #112508

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Tweak spans for self arg, fix borrow suggestion for signature mismatch #112508

merged 4 commits into from
Jul 22, 2023

Conversation

compiler-errors
Copy link
Member

  1. Adjust a suggestion message that was annoying me
  2. Fix debug ice: failed to remove lifetime from suggestion #112503 by recording the right spans for the self part of the &self 0th argument
  3. Remove the suggestion for adjusting a trait signature on type mismatch, bc that's gonna probably break all the other impls of the trait even if it fixes its one usage 😅

@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2023
@chenyukang
Copy link
Member

I'm not sure why the previous message annoying you, as a non-native English speaker, the previous message is easier to understand, and it's shorter 😁

And we are also suggesting how to change the code, so I think it's clear enough?

@compiler-errors
Copy link
Member Author

compiler-errors commented Jun 11, 2023 •
edited
Loading

@chenyukang:

I think it's pretty vague, especially when the suggestion is far away from the code that the E0277 is being reported.

Also, at least in my head, adding & to an argument type is not "borrowing the argument", it's changing the signature. Borrowing an argument would be like... adding & to an argument at the call site, not the definition site.

@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the trait-sig-lifetime-sugg-ice branch from ab9da33 to 8745ae2 Compare June 28, 2023 18:08
@compiler-errors compiler-errors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2023
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 22, 2023

📌 Commit 8745ae2 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2023
@bors
Auto merge of rust-lang#113968 - matthiaskrgr:rollup-7vdfcba, r=matth…
a6fbd1c 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112508 (Tweak spans for self arg, fix borrow suggestion for signature mismatch)
 - rust-lang#113901 (Get rid of subst-relate incompleteness in new solver)
 - rust-lang#113948 (Fix rustc-args passing issue in bootstrap)
 - rust-lang#113950 (Remove Scope::Elision from bound-vars resolution.)
 - rust-lang#113957 (Add regression test for issue rust-lang#113941 - naive layout isn't refined)
 - rust-lang#113959 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ed5f09 into rust-lang:master Jul 22, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 22, 2023
@compiler-errors compiler-errors deleted the trait-sig-lifetime-sugg-ice branch August 11, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 left review comments

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

debug ice: failed to remove lifetime from suggestion
7 participants
@compiler-errors @rustbot @chenyukang @cjgillot @bors @tgross35 @wesleywiser