Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on unconstrained lifetime in RPITIT #112611

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #109468

The only thing is that I had to split tests/ui/impl-trait/in-trait/method-signature-matches.rs into a bunch of different revisions because some error aren't being emitted if all the different examples are all together in one file 🤔

r? @oli-obk just because i know you'll review it, feel free to re-roll

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 14, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 14, 2023

oof subtle. Glad it'll be gone once the assoc type desugaring refactoring is done

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 14, 2023

📌 Commit bc78d0c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112584 (loongarch64-none*: Remove environment component from llvm target)
 - rust-lang#112600 (Introduce a `Stable` trait to translate MIR to SMIR)
 - rust-lang#112605 (Improve docs/clean up negative overlap functions)
 - rust-lang#112611 (Error on unconstrained lifetime in RPITIT)
 - rust-lang#112612 (Fix explicit-outlives-requirements lint span)
 - rust-lang#112613 (Fix rustdoc-gui tests on Windows)
 - rust-lang#112620 (Fix small typo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8aff112 into rust-lang:master Jun 14, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 14, 2023
@compiler-errors compiler-errors deleted the unconstrained-lt-in-rpitit branch August 11, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unconstrained lifetimes are allowed on return-position-impl-trait-in-trait impl methods
4 participants