-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark map_or
as #[must_use]
#112655
Merged
Merged
Mark map_or
as #[must_use]
#112655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 15, 2023
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
must_use_map_or
branch
from
June 15, 2023 13:34
9214ce3
to
1e66366
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
must_use_map_or
branch
from
June 15, 2023 15:30
1e66366
to
ea5b049
Compare
seems these changes are more for t-libs than t-compiler @rustbot label -T-compiler |
rustbot
removed
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Jul 13, 2023
@rustbot author |
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 30, 2023
rust-cloud-vms
bot
force-pushed
the
must_use_map_or
branch
from
July 30, 2023 10:23
ea5b049
to
90f9640
Compare
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Jul 30, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 30, 2023
…rkingjubilee Mark `map_or` as `#[must_use]` I don't know what else to say. r? libs
This was referenced Jul 30, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110056 (Fix the example in document for WaitTimeoutResult::timed_out) - rust-lang#112655 (Mark `map_or` as `#[must_use]`) - rust-lang#114018 (Make `--error-format human-annotate-rs` handle multiple files) - rust-lang#114068 (inline format!() args up to and including rustc_middle (2)) - rust-lang#114223 (Documentation: Fix Stilted Language in Vec->Indexing) - rust-lang#114227 (Add tidy check for stray rustfix files) r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 11, 2023
…rkingjubilee Mark `map_or` as `#[must_use]` I don't know what else to say. r? libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what else to say.
r? libs