-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[-Ztrait-solver=next, mir-typeck] instantiate hidden types in the root universe #112703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
compiler-errors
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all you need to do is amend the commit with the blessed stderr? If so, r=me after doing that.
@rustbot author |
a3476df
to
a72013f
Compare
compiler-errors
approved these changes
Jun 24, 2023
@bors r+ rollup (new solver) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 24, 2023
…ompiler-errors [-Ztrait-solver=next, mir-typeck] instantiate hidden types in the root universe Fixes an ICE in the test `member-constraints-in-root-universe`. Main motivation is to make rust-lang#112691 pass under the new solver. r? `@compiler-errors`
This was referenced Jun 24, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2023
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#112703 ([-Ztrait-solver=next, mir-typeck] instantiate hidden types in the root universe) - rust-lang#112854 (fix: add cfg diagnostic for unresolved import error) - rust-lang#112912 (style-guide: Rewrite let-else section for clarity, without changing formatting) - rust-lang#112915 (Update runtests.py : grammar correction) - rust-lang#112971 (issue template: add clippy entry which points to the clippy repo) - rust-lang#112989 (Add a regression test for rust-lang#109141) - rust-lang#113002 (bootstrap: Backup `settings.json` to the correct filename) - rust-lang#113003 (Fix old python deprecation check in x.py) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an ICE in the test
member-constraints-in-root-universe
.Main motivation is to make #112691 pass under the new solver.
r? @compiler-errors