-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Lrc<Box<dyn CodegenBackend>>
.
#112913
Avoid Lrc<Box<dyn CodegenBackend>>
.
#112913
Conversation
Because `Lrc<Box<T>>` is silly. (Clippy warns about `Rc<Box<T>>` and `Arc<Box<T>>`, and it would warn here if (a) we used Clippy with rustc, and (b) Clippy knew about `Lrc`.)
r=me unless you want a review specifically from bjorn |
@bors r=compiler-errors rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2efe091): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 661.846s -> 661.969s (0.02%) |
Those performance results are noise, this change should have had no effect on perf. |
Because
Lrc<Box<T>>
is silly. (Clippy warns aboutRc<Box<T>>
andArc<Box<T>>
, and it would warn here if (a) we used Clippy with rustc, and (b) Clippy knew aboutLrc
.)r? @bjorn3