Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #112967

Closed
wants to merge 17 commits into from

Commits on Jun 15, 2023

  1. Configuration menu
    Copy the full SHA
    0d6da78 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Configuration menu
    Copy the full SHA
    dd620aa View commit details
    Browse the repository at this point in the history
  2. Better error message

    compiler-errors committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    32f83e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    aacd702 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add @files command

    GuillaumeGomez committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    65a7047 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    752fb52 View commit details
    Browse the repository at this point in the history
  3. Fix rustdoc-gui tester

    GuillaumeGomez committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    616469a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d70faf3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2f3bed0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2f1939a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7b55779 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#112643 - compiler-errors:sized-obl-for-arg,…

    … r=wesleywiser
    
    Always register sized obligation for argument
    
    Removes a "hack" that skips registering sized obligations for parameters that are simple identifiers. This doesn't seem to affect diagnostics because we're probably already being smart enough about deduplicating identical error messages anyways.
    
    Fixes rust-lang#112608
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e5300e4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#112740 - GuillaumeGomez:link-to-search-chap…

    …ter, r=notriddle
    
    Add link to rustdoc book search chapter in help popover
    
    One thing that was missing in the rustdoc output and its help popover was a link back to the search feature chapter in the rustdoc book.
    
    It looks like this:
    
    ![image](https://github.com/rust-lang/rust/assets/3050060/425413e5-e734-4d40-b675-8b2dcef874a2)
    
    r? ```@notriddle```
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3ae9c81 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#112810 - compiler-errors:dont-ice-on-bad-la…

    …yout, r=wesleywiser
    
    Don't ICE on unnormalized struct tail in layout computation
    
    1. We try to compute a `SizeSkeleton` even if a layout error occurs, but we really only need to do this if we get `LayoutError::Unknown`, since that means our type is too polymorphic to actually compute the full layout. If we have other errors, like `LayoutError::NormalizationError` or `LayoutError::Cycle`, then we can't really make any progress, since this represents an actual error.
    2. Avoid using `normalize_erasing_regions` and `struct_tail_erasing_lifetimes` since those ICE on normalization errors, and since we may call `layout_of` in HIR typeck, we don't know for certain that we're on the happy path.
    
    Fixes rust-lang#112736
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    c4b7a82 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#112925 - oli-obk:timeout_lint, r=cjgillot

    Stop hiding const eval limit in external macros
    
    fixes rust-lang#112748
    
    We don't emit a hard error if there was a previous deny lint triggering with the same message. If that lint ends up not being emitted, we ICE and don't emit an error either.
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ed22f48 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#112960 - GuillaumeGomez:rustdoc-files-check…

    …, r=notriddle
    
    [tests/rustdoc] Add @files command
    
    The ````@!has```` checks is very problematic as it wouldn't catch if the file scheme is updated and the file is generated again. ````@files```` allows to ensure that the given folder contains exactly the provided entries (files and folders).
    
    I'm wondering if we should forbid the ````@!has```` for files. To be discussed after this PR I suppose.
    
    r? ```@notriddle```
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    2df1b0b View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#112962 - GuillaumeGomez:fix-rustdoc-gui-tes…

    …ter, r=ozkanonur
    
    Fix rustdoc gui tester
    
    Problem was that the `main` was always exiting with `0`, whether or not there was an error. It led to failing GUI tests being ignored in the CI since no one saw them.
    
    r? ``@klensy``
    matthiaskrgr committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    692ac9c View commit details
    Browse the repository at this point in the history