-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests impl via obj unless denied #113020
Merged
bors
merged 1 commit into
rust-lang:master
from
AnbyKatz:add-tests-impl-via-obj-unless-denied
Jun 28, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#![feature(ptr_metadata)] | ||
// Address issue #112737 -- ICE with dyn Pointee | ||
extern crate core; | ||
use core::ptr::Pointee; | ||
|
||
fn unknown_sized_object_ptr_in(_: &(impl Pointee<Metadata = ()> + ?Sized)) {} | ||
|
||
fn raw_pointer_in(x: &dyn Pointee<Metadata = ()>) { | ||
unknown_sized_object_ptr_in(x) | ||
//~^ ERROR type mismatch resolving `<dyn Pointee<Metadata = ()> as Pointee>::Metadata == ()` | ||
} | ||
|
||
fn main() { | ||
raw_pointer_in(&42) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
error[E0271]: type mismatch resolving `<dyn Pointee<Metadata = ()> as Pointee>::Metadata == ()` | ||
--> $DIR/ice-with-dyn-pointee-errors.rs:9:33 | ||
| | ||
LL | unknown_sized_object_ptr_in(x) | ||
| --------------------------- ^ expected `()`, found `DynMetadata<dyn Pointee<Metadata = ...>>` | ||
| | | ||
| required by a bound introduced by this call | ||
| | ||
= note: expected unit type `()` | ||
found struct `DynMetadata<dyn Pointee<Metadata = ()>>` | ||
note: required by a bound in `unknown_sized_object_ptr_in` | ||
--> $DIR/ice-with-dyn-pointee-errors.rs:6:50 | ||
| | ||
LL | fn unknown_sized_object_ptr_in(_: &(impl Pointee<Metadata = ()> + ?Sized)) {} | ||
| ^^^^^^^^^^^^^ required by this bound in `unknown_sized_object_ptr_in` | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0271`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// run-pass | ||
#![feature(ptr_metadata)] | ||
// Address issue #112737 -- ICE with dyn Pointee | ||
extern crate core; | ||
use core::ptr::Pointee; | ||
|
||
fn raw_pointer_in(_: &dyn Pointee<Metadata = ()>) {} | ||
|
||
fn main() { | ||
raw_pointer_in(&42) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please either reference #112737 in a comment or change the filename to issue-112737.rs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather the issue referenced in a comment