Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: redesign [+]/[−] controls #113074

Closed
wants to merge 5 commits into from
Closed

rustdoc: redesign [+]/[−] controls #113074

wants to merge 5 commits into from

Commits on Dec 6, 2023

  1. rustdoc: redesign [+]/[−] controls 

    This is a continuation of rust-lang#107658 and rust-lang#59851, making the toggles
consistent with other buttons, instead of looking like syntax.

The tactics to improve the look of these controls:

* When the toggle is expanded, the minus sign remains as dark as
  before, but the border is lighter. The plus sign has a border
  that's the same color as the label (black, on the default theme).
  This makes expansion buttons more prominent, easier to tell
  apart from collapse buttons.
* The plus sign is slightly taller than wide, also to make
  it easier to tell apart from the minus sign.
  * The use of crispEdges has to get a bit strategic to make this
    come out right. I've tested it on Firefox, Safari, and
    Chromium, but it's a bit hard to be sure it works right on
    all setups.
  * Does anybody know some trick to do crispEdges on only the
    X axis, while still allowing antialiasing on the Y?
* The "toggle all" button is modeled after the Help and Settings
  buttons, with a matching border, width, and +/− label.
    @notriddle
    notriddle committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6930b14 View commit details
    Browse the repository at this point in the history

  2. rustdoc: tweak outline color on minus button and dark toggle all

    @notriddle
    notriddle committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    73d8119 View commit details
    Browse the repository at this point in the history

  3. rustdoc: make toggle buttons a bit bigger

    @notriddle
    notriddle committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e930ab3 View commit details
    Browse the repository at this point in the history

  4. rustdoc: improve alignment of out-of-band page info

    @notriddle
    notriddle committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1425235 View commit details
    Browse the repository at this point in the history

  5. rustdoc: make the toggle buttons look more like the big one

    @notriddle
    notriddle committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    36f75e4 View commit details
    Browse the repository at this point in the history