Use CoverageKind::as_operand_id instead of manually reimplementing it
#113079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
The implementation of rust/compiler/rustc_middle/src/mir/coverage.rs Lines 113 to 121 in 2a15bda |
|
@rustbot label +A-code-coverage |
rustbot
added
the
A-code-coverage
bors
added
S-waiting-on-bors
|
⌛ Testing commit fbb2079 with merge a97012596425a6ee45213ba88b194149ff2f002a... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry mips segfault |
bors
added
S-waiting-on-bors
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Jun 27, 2023
Use `CoverageKind::as_operand_id` instead of manually reimplementing it These two pieces of code are functionally equivalent to the `CoverageKind::as_operand_id` method that already exists, and is already used elsewhere in this file. This slightly reduces the amount of code that manually pattern-matches on `CoverageKind`.
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Jun 27, 2023
Use `CoverageKind::as_operand_id` instead of manually reimplementing it These two pieces of code are functionally equivalent to the `CoverageKind::as_operand_id` method that already exists, and is already used elsewhere in this file. This slightly reduces the amount of code that manually pattern-matches on `CoverageKind`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112518 (Detect actual span for getting unexpected token from parsing macros) - rust-lang#112978 (Add suggestion for bad block fragment error) - rust-lang#113068 (bootstrap: rename 'user' profile to 'dist') - rust-lang#113079 (Use `CoverageKind::as_operand_id` instead of manually reimplementing it) - rust-lang#113089 (Export AnalysisResults trait in rustc_mir_dataflow) - rust-lang#113093 (`thir`: Add `Become` expression kind) - rust-lang#113096 (Remove unused struct and tweak format macro uses) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two pieces of code are functionally equivalent to the
CoverageKind::as_operand_idmethod that already exists, and is already used elsewhere in this file.This slightly reduces the amount of code that manually pattern-matches on
CoverageKind.