Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tracking issue for const_cstr_from_ptr #113252

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 1, 2023

Tracking issue #101719 was for const_cstr_methods, #113219 is a new issue specific for const_cstr_from_ptr.

(I believe #101719 could also be closed)

@rustbot label +T-libs-api +A-docs

Tracking issue rust-lang#101719 was for `const_cstr_methods`, rust-lang#113219 is a new
issue specific for `const_cstr_from_ptr`.
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 1, 2023
@tgross35
Copy link
Contributor Author

@joshtriplett gentle ping if you get the chance, this is probably the easiest PR out there :)

@ChrisDenton
Copy link
Member

lgtm

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 21, 2023

📌 Commit 5ed429f has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2023
…ing-issue, r=ChrisDenton

Update the tracking issue for `const_cstr_from_ptr`

Tracking issue rust-lang#101719 was for `const_cstr_methods`, rust-lang#113219 is a new issue specific for `const_cstr_from_ptr`.

(I believe rust-lang#101719 could also be closed)

`@rustbot` label +T-libs-api +A-docs
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2023
…ing-issue, r=ChrisDenton

Update the tracking issue for `const_cstr_from_ptr`

Tracking issue rust-lang#101719 was for `const_cstr_methods`, rust-lang#113219 is a new issue specific for `const_cstr_from_ptr`.

(I believe rust-lang#101719 could also be closed)

``@rustbot`` label +T-libs-api +A-docs
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112490 (Remove `#[cfg(all())]` workarounds from `c_char`)
 - rust-lang#113252 (Update the tracking issue for `const_cstr_from_ptr`)
 - rust-lang#113442 (Allow limited access to `OsString` bytes)
 - rust-lang#113876 (fix docs & example for `std::os::unix::prelude::FileExt::write_at`)
 - rust-lang#113898 (Fix size_hint for EncodeUtf16)
 - rust-lang#113934 (Multibyte character removal in String::pop and String::remove doctests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 58a4be1 into rust-lang:master Jul 22, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 22, 2023
@tgross35 tgross35 deleted the const-cstr-from-ptr-tracking-issue branch July 22, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants