-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to indexmap 2.0.0 #113304
Upgrade to indexmap 2.0.0 #113304
Conversation
The new version was already added to the tree as an indirect dependency in rust-lang#113046, but now our direct dependents are using it too.
(rustbot has picked a reviewer for you, use r? to override) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The specific crates have changed, but the expected "help" remains.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (52d8c49): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.369s -> 672.679s (0.34%) |
@cuviper I'm curious about this perf regression, which looks consistent enough not to be just noise. Do you have any hypotheses about why this might be the case? |
@djc, I don't really know -- not much actually changed in the implementation except maybe indexmap-rs/indexmap#263. But its dependency on |
The new version was already added to the tree as an indirect dependency
in #113046, but now our direct dependents are using it too.