Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to indexmap 2.0.0 #113304

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Upgrade to indexmap 2.0.0 #113304

merged 2 commits into from
Jul 4, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 3, 2023

The new version was already added to the tree as an indirect dependency
in #113046, but now our direct dependents are using it too.

The new version was already added to the tree as an indirect dependency
in rust-lang#113046, but now our direct dependents are using it too.
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 3, 2023
@rustbot

This comment was marked as resolved.

@rust-log-analyzer

This comment was marked as resolved.

The specific crates have changed, but the expected "help" remains.
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2023

📌 Commit 2b091ff has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2023
@bors
Copy link
Contributor

bors commented Jul 4, 2023

⌛ Testing commit 2b091ff with merge 52d8c49...

@bors
Copy link
Contributor

bors commented Jul 4, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 52d8c49 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2023
@bors bors merged commit 52d8c49 into rust-lang:master Jul 4, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52d8c49): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.4%, 1.2%] 20
Regressions ❌
(secondary)
0.7% [0.3%, 1.2%] 16
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.5%] 4
All ❌✅ (primary) 0.8% [0.4%, 1.2%] 20

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-3.5%, -1.1%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.369s -> 672.679s (0.34%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 4, 2023
@cuviper cuviper deleted the indexmap-2 branch July 4, 2023 18:13
@djc
Copy link
Contributor

djc commented Jul 6, 2023

@cuviper I'm curious about this perf regression, which looks consistent enough not to be just noise. Do you have any hypotheses about why this might be the case?

@cuviper
Copy link
Member Author

cuviper commented Jul 8, 2023

@djc, I don't really know -- not much actually changed in the implementation except maybe indexmap-rs/indexmap#263. But its dependency on hashbrown also went from 0.12 to 0.14, so there could be more that changed there. I'm comforted that cycles and wall-time don't show much change though, so it doesn't seem like a real loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants