-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TyCtxt::mk_x
to Ty::new_x
where applicable
#113377
Conversation
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
18728d0
to
12138b8
Compare
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Show resolved
Hide resolved
@@ -140,7 +141,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriInterpCxExt<'mir, 'tcx> { | |||
let size = u64::try_from(os_str.len()).unwrap().checked_add(1).unwrap(); // Make space for `0` terminator. | |||
let this = self.eval_context_mut(); | |||
|
|||
let arg_type = this.tcx.mk_array(this.tcx.types.u8, size); | |||
let arg_type = Ty::new_array(this.tcx.tcx,this.tcx.types.u8, size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subtree formatting :(
(oh and @bjorn3 too, you're a subtree owner too!) |
Noting as a retrospective, but not a blocker of this PR, that we have a lot of code even within the This is not this PR's fault, but the fault of not having formatting for let-chains in-tree. I've chatted separately with @calebcartwright to understand how we can get provisional formatting into rust sooner than later now that we (T-style) have decided on a new nightly-features formatting policy 😉 |
Additional nice-to-haves after this PR lands (just the ones that come to mind):
|
⌛ Testing commit 6ce1c89 with merge b3485f33f946f7556722b47529e79f82632fb229... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4dd1719): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.042s -> 656.237s (-0.43%) |
…ler-errors Move `TyCtxt::mk_x` to `Ty::new_x` where applicable Part of rust-lang/compiler-team#616 turns out there's a lot of places we construct `Ty` this is a ridiculously huge PR :S r? `@oli-obk`
Part of rust-lang/compiler-team#616
turns out there's a lot of places we construct
Ty
this is a ridiculously huge PR :Sr? @oli-obk