-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap paths for ~/.cargo in UI tests #113611
Conversation
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
oh, apparently the reason i didn't notice this earlier is because sources were broken for foreign crates until recently lol #111146 |
@bors r+ rollup |
…=ozkanonur Remap paths for ~/.cargo in UI tests Users won't have the original cargo registry from the CI builder available, even if they have `rust-src` installed. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled. Helps with rust-lang#112143.
@bors r- rollup=iffy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6e84f62
to
cde05ee
Compare
@bors r=ozkanonur |
⌛ Testing commit cde05ee with merge 41031f1f347df1df8619fd30d17fd832ce09c17b... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
I don't understand this failure. It doesn't replicate locally on Linux - I can try in a bit with an apple machine. The debuginfo it expects to be present isn't related to ~/.cargo:
so I am not quite sure what could be going wrong here. |
Users won't have the original cargo registry from the CI builder available, even if they have `rust-src` installed. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled.
cde05ee
to
ae44ad5
Compare
oh, this was done as part of #115869 |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Users won't have the original cargo registry from the CI builder available, even if they have
rust-src
installed. Don't show their sources in UI tests even if they're available. As a happy side-effect, this fixes a few UI tests when download-rustc is enabled.Helps with #112143.