Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't replace opaque types under binders with infer vars #113648

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

aliemjay
Copy link
Member

@aliemjay aliemjay commented Jul 13, 2023

Fixes an ICE in the ui test code.

Fixes #109636
Fixes #109281
Fixes #86800

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2023
@matthiaskrgr
Copy link
Member

@rust-log-analyzer

This comment has been minimized.

@aliemjay
Copy link
Member Author

@matthiaskrgr good call, this should fix all these issues. I've hit this issue accidentally and was too lazy to search the issue tracker :)

@compiler-errors
Copy link
Member

ui/generic-associated-types/issue-90014-tait2.rs is an interesting failure. Maybe we should only care if the escaping vars are actually captured by the opaque, and replace the others by something like 'static since they're bivariant lifetimes anyways?

@aliemjay
Copy link
Member Author

ui/generic-associated-types/issue-90014-tait2.rs is fixed by #113690.

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jul 19, 2023

needs a rebase now that #113690 has landed

@oli-obk
Copy link
Contributor

oli-obk commented Aug 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2023

📌 Commit 2e83a72 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2023
@bors
Copy link
Contributor

bors commented Aug 6, 2023

⌛ Testing commit 2e83a72 with merge d6d9972777928945b047cc0dffa33475399045da...

@bors
Copy link
Contributor

bors commented Aug 6, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d6d9972777928945b047cc0dffa33475399045da to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2023
@bors
Copy link
Contributor

bors commented Aug 6, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@matthiaskrgr
Copy link
Member

@bors retry Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@bors
Copy link
Contributor

bors commented Aug 6, 2023

⌛ Testing commit 2e83a72 with merge e595409...

@bors
Copy link
Contributor

bors commented Aug 6, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e595409 to master...

@bors bors merged commit e595409 into rust-lang:master Aug 6, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 6, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d6d9972777928945b047cc0dffa33475399045da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.0% [-4.9%, -2.0%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.0% [-4.9%, -2.0%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.351s -> 650.741s (-0.09%)

@aliemjay aliemjay deleted the opaque-binder-ice branch August 6, 2023 17:17
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e595409): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.3% [-5.4%, -3.4%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.3% [-5.4%, -3.4%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.428s -> 650.515s (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
8 participants