-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update ubuntu:20.04 builders to 22.04 #113931
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This is consistent with what we had from `arm-linux-gnueabihf-gcc` in the `ubuntu:20.04` base.
@bors r+ rollup=never Nothing here looks too suspicious... |
I think that the bump from 20.04 to 22.04 updates the glibc version. Do we care about this for some of the modified dist builders? Or is this only relevant for x64 Linux gnu? |
Hmm, I suppose it is relevant to any Do we care about |
If we do care, maybe we could fork those |
Can you check against https://doc.rust-lang.org/beta/rustc/platform-support.html? I think if we don't document a version we should be fine to bump as a nonevent, otherwise let's bump the documentation at least. (My quick scroll suggests it's not unlikely this doesn't change anything, but I'm not sure) |
Hmm, |
☀️ Test successful - checks-actions |
The glibc versions under Tier 2 (without host) should be updated, but they're already wrong. They should have been updated for #81521 at least, and there's a deja vu comment about compat and dynamic linking... 😅 I'll send an update, including a footnote about that applicability. |
These Tier 2 non-host targets were affected by the update to `ubuntu:22.04` in rust-lang#113931, but the platform support page was already out of date after rust-lang#81521 updated to `ubuntu:20.04`. They are now listed for kernel 5.15 and glibc 2.35 as found in 22.04, and a new footnote mentions that this only matters when using the dynamic `libstd.so`.
LLVM alone took over 1.5 hours in that build, but only 5 minutes in the next -- hooray for sccache! |
Finished benchmarking commit (b6dd153): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.027s -> 649.861s (-0.03%) |
This is mostly just maintenance to avoid bitrotting, but 22.04 also updates to cmake 3.22, so they don't need the manual builds from #113714 anymore.