Revert "add tidy check that forbids issue ui test filenames" #114133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 13e2abf. Reverting because an MCP was requested and it turned out there was a lack of a consensus on what to do in this area.
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
@bors r+ |
bors
added
S-waiting-on-bors
|
(Thank you to both @workingjubilee and @jackh726 for following up here.) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2023
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#97571 (Add documentation on v0 symbol mangling.) - rust-lang#114122 (tests/ui/hello_world/main.rs: Remove FIXME (rust-lang#62277)) - rust-lang#114133 (Revert "add tidy check that forbids issue ui test filenames") - rust-lang#114139 (Make `--print` with path unstable) r? `@ghost` `@rustbot` modify labels: rollup
|
Cc #113583 (since I was very confused when I failed to find this code in the source and I did check the backreferences of the original PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 13e2abf.
Reverting because an MCP was requested and it turned out there was a lack of a consensus on what to do in this area.