unix/kernel_copy.rs: copy_file_range_candidate allows empty output files #114373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Sanity checking myself here (see |
the8472
reviewed
Aug 2, 2023
the8472
reviewed
Aug 3, 2023
This is for rust-lang#114341 The `meta.len() > 0` condition here is intended for inputs only, ie. when input is in the `/proc` filesystem as documented. That inaccurately included empty output files which are then shunted to the sendfile() routine leading to higher than nescessary IO util in some cases, specifically with CoW filesystems like btrfs. Further, `NoneObtained` is not relevant in this context, so remove it. Simply, determine what is input or output given the passed enum Unit.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113534 (Forbid old-style `simd_shuffleN` intrinsics) - rust-lang#113999 (Specify macro is invalid in certain contexts) - rust-lang#114348 (Migrate GUI colors test to original CSS color format) - rust-lang#114373 (unix/kernel_copy.rs: copy_file_range_candidate allows empty output files) - rust-lang#114404 (Migrate GUI colors test to original CSS color format) - rust-lang#114409 (builtin impl confirmation wuhu) - rust-lang#114429 (compiletest: Handle non-utf8 paths (fix FIXME)) - rust-lang#114431 (Enable tests on rustc_codegen_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #114341
The
meta.len() > 0condition here is intended for inputs only, ie. when input is in the/procfilesystem as documented.That inaccurately included empty output files which are then shunted to the sendfile() routine leading to higher than nescessary IO util in some cases, specifically with CoW filesystems like btrfs.
Simply, determine what is input or output given the passed boolean.