-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hotness data to LLVM remarks #114439
Add hotness data to LLVM remarks #114439
Conversation
This comment has been minimized.
This comment has been minimized.
This makes sure that if PGO is used, remarks generated using `-Zremark-dir` will include the `Hotness` attribute.
ad8cc88
to
93bdc01
Compare
To avoid compile time impact #114568 (comment), can you also check that PGO information is available before requesting hotness data? |
Would it be enough to just check if we're currently compiling with |
Checking for |
Ok, done. |
@bors delegate=Kobzol |
67bd1b1
to
9602581
Compare
@bors r=tmiasko |
📌 Commit 960258163e22387e4c229b413de1d419bf3fec1d has been approved by It is now in the queue for this repository. |
⌛ Testing commit 960258163e22387e4c229b413de1d419bf3fec1d with merge 51b042919f98f280adb72f8915167adcec870667... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
That doesn't seem good. I don't really have |
9602581
to
9d417d7
Compare
Oh, ok, that's one way to solve it 😆 Thank you both. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f525bb4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.076s -> 632.146s (0.17%) |
Slight improvement of #113040. This makes sure that if PGO is used, remarks generated using
-Zremark-dir
will include theHotness
attribute.r? @tmiasko