Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #114697

Merged
merged 11 commits into from
Aug 10, 2023
Merged

Rollup of 5 pull requests #114697

merged 11 commits into from
Aug 10, 2023

Commits on Jul 31, 2023

  1. better error handling for rust.codegen-backends on deserialization

    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b602cf5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    762df46 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Bugfix: 'can_have_side_effects()' would return 'false' for struct/enu…

    …m/array/tuple literals unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point
    MortenLohne committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    75d5f10 View commit details
    Browse the repository at this point in the history
  2. Update profile_sample_use.md

    Just remove a typo.
    zamazan4ik committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f359139 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    553bfe2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f8bb9d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#114278 - ozkanonur:validate-codegen-backend…

    …-config, r=clubby789
    
    better error handling for `rust.codegen-backends` on deserialization
    
    Fixes rust-lang#109315
    matthiaskrgr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b9648d4 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#114674 - clubby789:clubby-vacation, r=compi…

    …ler-errors
    
    Add clubby789 to `users_on_vacation`
    
    I'm on holiday until the 30th of August so won't be able to take on reviews until then
    matthiaskrgr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5b55863 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#114678 - MortenLohne:bugfix/hir-has-side-ef…

    …fects, r=compiler-errors
    
    `Expr::can_have_side_effects()` is incorrect for struct/enum/array/tuple literals
    
    It would return 'false' unless *all* sub-expressions had side effects. This would easily allow side effects to slip through, and also wrongly label empty literals as having side effects. Add some tests for the last point
    
    The function is only used for simple lints and error messages, so not a serious bug.
    matthiaskrgr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    710b989 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#114681 - zamazan4ik:master, r=compiler-errors

    doc (unstable-book): fix a typo
    
    Just fix a small typo.
    matthiaskrgr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7e3616d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#114684 - compiler-errors:redundant-resolves…

    …, r=lcnr
    
    Remove redundant calls to `resolve_vars_with_obligations`
    
    I've been auditing the calls to `resolve_vars_with_obligations` for the new solver, and have found a few that have no effect on diagnostics. Let's just remove 'em.
    
    Also remove a redundant `resolve_vars_with_obligations_and_mutate_fulfillment` call.
    
    r? ``@lcnr``
    matthiaskrgr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5f0d585 View commit details
    Browse the repository at this point in the history