Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added empty() to Peekable #11479

Merged
merged 2 commits into from
Jan 17, 2014
Merged

added empty() to Peekable #11479

merged 2 commits into from
Jan 17, 2014

Conversation

khodzha
Copy link
Contributor

@khodzha khodzha commented Jan 11, 2014

to fix #11218

@alexcrichton
Copy link
Member

If we do take this, it should probably be called is_empty because sometimes foo.empty() looks like you're actually emptying it, and we have existing is_empty methods on containers.

@brson
Copy link
Contributor

brson commented Jan 17, 2014

Thanks!

@khodzha
Copy link
Contributor Author

khodzha commented Jan 17, 2014

@brson should i close this pull request?

@jdm
Copy link
Contributor

jdm commented Jan 17, 2014

Nope, it bounced due to test failures. They look unrelated to me, so I'm retrying.

bors added a commit that referenced this pull request Jan 17, 2014
@bors
auto merge of #11479 : khodzha/rust/peekable_empty, r=brson
1e1871f 
to fix #11218
@bors bors closed this Jan 17, 2014
@bors bors merged commit 4993c7c into rust-lang:master Jan 17, 2014
@khodzha khodzha deleted the peekable_empty branch January 17, 2014 17:18
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 25, 2023
@bors
Auto merge of rust-lang#11483 - y21:path_ends_with, r=Alexendoo
daadab5 
new lint: `path_ends_with_ext`

Closes rust-lang#11479

Not sure if it needs more test cases. I couldn't come up with any other ones, but it is a pretty simple lint logic wise with not too many checks

changelog: new lint: [`path_ends_with_ext`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add empty method to iterators
5 participants
@khodzha @alexcrichton @brson @jdm @bors