Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of global state and driver refactors #114803

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Couple of global state and driver refactors #114803

merged 5 commits into from
Aug 15, 2023

Commits on Aug 13, 2023

  1. Remove reached_eof from ParseSess 

    It was only ever set in a function which isn't called anywhere.
    @bjorn3
    bjorn3 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    ef2da4a View commit details
    Browse the repository at this point in the history

  2. Inline queries for crate_name, crate_types and stable_crate_id 

    All of them are not exported from rustc_interface and used only during
global_ctxt(). Inlining them makes it easier to follow the order of
queries and slightly reduces line count.
    @bjorn3
    bjorn3 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    4a6de8e View commit details
    Browse the repository at this point in the history

  3. Pass WorkProductMap to build_dep_graph instead of FxIndexMap 

    Constructing an FxIndexMap is useless work as the iteration order never
matters.
    @bjorn3
    bjorn3 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    980143b View commit details
    Browse the repository at this point in the history

  4. Remove metadata_loader query 

    It is only used by CrateLoader. We can store the metadata loader in
CStore instead which CrateLoader has access to.
    @bjorn3
    bjorn3 committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    c624738 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Fix review comment

    @bjorn3
    bjorn3 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    223c43b View commit details
    Browse the repository at this point in the history