Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo: affect -> effect #114861

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix typo: affect -> effect #114861

merged 1 commit into from
Aug 16, 2023

Conversation

RalfJung
Copy link
Member

I just realized I made a silly typo when writing that comment...

@wesleywiser
Copy link
Member

@bors r+ rollup

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2023
@cuviper cuviper assigned wesleywiser and unassigned cuviper Aug 15, 2023
@bors
Copy link
Contributor

bors commented Aug 15, 2023

📌 Commit e1e6c00 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2023
@GuillaumeGomez
Rollup merge of rust-lang#114861 - RalfJung:no-effect, r=wesleywiser
8ebf823 
fix typo: affect -> effect

I just realized I made a silly typo when writing that comment...
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 15, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
@bors
Auto merge of rust-lang#114879 - matthiaskrgr:rollup-tim571q, r=matth…
60713f4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114721 (Optimizing the rest of bool's Ord implementation)
 - rust-lang#114746 (Don't add associated type bound for non-types)
 - rust-lang#114779 (Add check before suggest removing parens)
 - rust-lang#114859 (Add trait related queries to SMIR's rustc_internal)
 - rust-lang#114861 (fix typo: affect -> effect)
 - rust-lang#114867 ([nit] Fix a comment typo.)
 - rust-lang#114871 (Update the link in the docs of `std::intrinsics`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6f27032 into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@RalfJung RalfJung deleted the no-effect branch August 17, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @wesleywiser @rustbot @bors @cuviper