-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references in VarDebugInfo #114904
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
r? compiler |
r? @davidtwco |
@bors r+ |
📌 Commit 8d08c02afad7349092cc7f96da339fe6f80947f1 has been approved by It is now in the queue for this repository. |
@bors p=1 Fixes P-critical issue. |
⌛ Testing commit 8d08c02afad7349092cc7f96da339fe6f80947f1 with merge 0649ebbfe67ebf7084bfbd04482f02cd961bca3a... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
This reverts commit 2ec0071.
8d08c02
to
b542c55
Compare
Blessed additional tests. |
⌛ Testing commit b542c55 with merge 769437d496f969df9a566bc106934420fd7a62f7... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors r=wesleywiser |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ccc3ac0): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 635.3s -> 634.129s (-0.18%) |
Performance wins outweigh losses. @rustbot label: +perf-regression-triaged |
Some of it also may be noise: changes in codegen debuginfo impacting check and doc builds, as well as opt without debuginfo. |
The codegen implementation is broken, and attempted to read uninitialized memory.
Fixes #114488