Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references in VarDebugInfo #114904

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

cjgillot
Copy link
Contributor

The codegen implementation is broken, and attempted to read uninitialized memory.

Fixes #114488

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member

r? compiler

@rustbot rustbot assigned b-naber and unassigned compiler-errors Aug 17, 2023
@b-naber
Copy link
Contributor

b-naber commented Aug 17, 2023

r? @davidtwco

@rustbot rustbot assigned davidtwco and unassigned b-naber Aug 17, 2023
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit 8d08c02afad7349092cc7f96da339fe6f80947f1 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@wesleywiser
Copy link
Member

@bors p=1

Fixes P-critical issue.

@bors
Copy link
Contributor

bors commented Aug 17, 2023

⌛ Testing commit 8d08c02afad7349092cc7f96da339fe6f80947f1 with merge 0649ebbfe67ebf7084bfbd04482f02cd961bca3a...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 17, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2023
@cjgillot
Copy link
Contributor Author

Blessed additional tests.
@bors r=wesleywiser

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit b542c55 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2023
@bors
Copy link
Contributor

bors commented Aug 17, 2023

⌛ Testing commit b542c55 with merge 769437d496f969df9a566bc106934420fd7a62f7...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 17, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2023
@cjgillot
Copy link
Contributor Author

@bors r=wesleywiser

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit 3798bca has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@bors
Copy link
Contributor

bors commented Aug 17, 2023

⌛ Testing commit 3798bca with merge ccc3ac0...

@bors
Copy link
Contributor

bors commented Aug 18, 2023

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing ccc3ac0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2023
@bors bors merged commit ccc3ac0 into rust-lang:master Aug 18, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 18, 2023
@cjgillot cjgillot deleted the no-ref-debuginfo branch August 18, 2023 06:36
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ccc3ac0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.3%, 1.3%] 10
Regressions ❌
(secondary)
1.4% [1.3%, 1.4%] 4
Improvements ✅
(primary)
-1.0% [-7.3%, -0.3%] 32
Improvements ✅
(secondary)
-2.1% [-2.4%, -1.6%] 4
All ❌✅ (primary) -0.6% [-7.3%, 1.3%] 42

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [0.7%, 6.0%] 4
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
-4.9% [-10.3%, -0.0%] 7
Improvements ✅
(secondary)
-2.1% [-3.0%, -1.2%] 3
All ❌✅ (primary) -1.9% [-10.3%, 6.0%] 11

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [1.3%, 5.2%] 4
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-8.5%, -1.0%] 7
Improvements ✅
(secondary)
-2.1% [-2.3%, -1.8%] 3
All ❌✅ (primary) -0.2% [-8.5%, 5.2%] 11

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.1%, 1.3%] 9
Regressions ❌
(secondary)
0.3% [0.0%, 0.9%] 8
Improvements ✅
(primary)
-0.3% [-0.9%, -0.0%] 92
Improvements ✅
(secondary)
-0.4% [-2.1%, -0.0%] 36
All ❌✅ (primary) -0.2% [-0.9%, 1.3%] 101

Bootstrap: 635.3s -> 634.129s (-0.18%)
Artifact size: 347.04 MiB -> 347.11 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 18, 2023
@nnethercote
Copy link
Contributor

Performance wins outweigh losses.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 18, 2023
@lqd
Copy link
Member

lqd commented Aug 18, 2023

Some of it also may be noise: changes in codegen debuginfo impacting check and doc builds, as well as opt without debuginfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferencePropagation exposed a latent miscompile, found in the wild with regex