refactor(lint): translate RenamedOrRemovedLint
#115152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
weihanglo
force-pushed
the
lint-refactor
branch
from
b702222 to
ef3e033
Compare
This comment was marked as outdated.
This comment was marked as outdated.
weihanglo
force-pushed
the
lint-refactor
branch
from
ef3e033 to
73152a3
Compare
compiler-errors
approved these changes
Aug 24, 2023
|
r? compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2023
Rollup of 9 pull requests Successful merges: - rust-lang#114987 (elaborate a bit on the (lack of) safety in 'Mmap::map') - rust-lang#115084 (Add smir `predicates_of`) - rust-lang#115117 (Detect and report nix shell) - rust-lang#115124 (kmc-solid: Import `std::sync::PoisonError` in `std::sys::solid::os`) - rust-lang#115152 (refactor(lint): translate `RenamedOrRemovedLint`) - rust-lang#115154 (Move some ui tests to subdirectories) - rust-lang#115167 (Fix ub-int-array test for big-endian platforms) - rust-lang#115172 (Add more tests for if_let_guard) - rust-lang#115177 (Add symbols for Clippy usage) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to address rust-lang/cargo#12495 and found that maybe I should refactor relevant lints a bit.
This PR translates
RenamedOrRemovedLintinto fluent file. To make diagnostic types clearer and easier to organize, this PR splits it into two structs.The second commit adds lifetime annotations for removing unnecessary clones. If people feel too noisy, we can revert such change.
Possibly relevant UI tests:
tests/ui/lint-removed*tests/ui/lint-renamed*tests/ui/rustdoc-renamed.rstests/rustdoc-ui/lints/unknown-renamed-lints.rs