-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks and improvements on SMIR around generics_of and predicates_of #115300
Conversation
Could not assign reviewer from: |
(rustbot has picked a reviewer for you, use r? to override) |
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
This comment has been minimized.
This comment has been minimized.
acee770
to
b82b70f
Compare
b82b70f
to
c94ac2b
Compare
c94ac2b
to
cf76099
Compare
I'm leaving the PR this way for @oli-obk to check it out, but I'm going to add a macro so we can have this *Def new type wrappers defined over |
This comment has been minimized.
This comment has been minimized.
cf76099
to
6031d6c
Compare
This comment has been minimized.
This comment has been minimized.
6031d6c
to
3e854c3
Compare
721377e
to
a0d49c1
Compare
cccdc8d
to
5ab9616
Compare
@bors r+ rollup |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111580 (Don't ICE on layout computation failure) - rust-lang#114923 (doc: update lld-flavor ref) - rust-lang#115174 (tests: add test for rust-lang#67992) - rust-lang#115187 (Add new interface to smir) - rust-lang#115300 (Tweaks and improvements on SMIR around generics_of and predicates_of) - rust-lang#115340 (some more is_zst that should be is_1zst) r? `@ghost` `@rustbot` modify labels: rollup
r? @oli-obk
This allows an API like the following ...
I didn't like that much
trait_def.trait_decl()
which is it possible but adding a method to a def_id that loads up a whole trait definition looks backwards to me.