[WIP] Support param bounds on non-lifetime binders #115362

compiler-errors · 2023-08-29T21:52:30Z

👀

r? @ghost

compiler-errors · 2023-08-29T21:52:37Z

@bors try @rust-timer queue

bors · 2023-08-29T21:52:46Z

⌛ Trying commit 3471faa6dbd43943bb8dc2e3bdedf59fab546439 with merge ff357375eca19961c0e26a765585b8cf4b3a1b3c...

bors · 2023-08-29T21:59:57Z

💔 Test failed - checks-actions

bors · 2023-09-03T13:50:45Z

☔ The latest upstream changes (presumably #115361) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-14T06:31:36Z

☔ The latest upstream changes (presumably #115751) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-10-18T14:25:34Z

☔ The latest upstream changes (presumably #116885) made this pull request unmergeable. Please resolve the merge conflicts.

fmease · 2023-10-19T19:07:39Z

Obviously, this is still WIP. Here's one observation I made while playing around with this patch:

trait Trait<T> {}
fn f(_: impl for<T: ?Sized> Trait<T>) {}

This successfully compiles (-Ztrait-solver=next ofc) while I don't think it should. impl for<T: ?Sized> Trait<T> isn't WF since the contained Trait<T> requires T: Sized to hold to be WF which isn't the case here. Cf: fn g<T: ?Sized>(_: impl Trait<T>) (ofc this is far from semantically equivalent) doesn't compile, rightly so.

compiler-errors · 2023-10-19T19:11:22Z

@fmease: Yeah, that's pre-existing.

#![feature(non_lifetime_binders)]

trait Trait<T> {}
fn f<S: for<T> Trait<T>>(_: S) {}
//~^ Recall that `for<T>` on stable == `for<T: ?Sized>`

This is likely due to one of the many !obligation.has_escaping_bound_vars() in wf code.

compiler-errors · 2023-12-18T17:55:28Z

@bors try @rust-timer queue

bors · 2023-12-18T17:56:38Z

⌛ Trying commit 82ae54c with merge 2e849e3...

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

bors · 2023-12-18T18:04:50Z

💔 Test failed - checks-actions

compiler-errors · 2023-12-18T18:16:20Z

@bors try @rust-timer queue

bors · 2023-12-18T18:17:30Z

⌛ Trying commit 335a142 with merge fc9bfc9...

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

rust-log-analyzer · 2023-12-18T18:32:40Z

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=rust-cloud-vms[bot]
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_3472885e-60bf-4300-9d7a-e5690d53436c
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=2ff5eb62837dfe3b2cdd2844996a18967575fa68
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_3472885e-60bf-4300-9d7a-e5690d53436c
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_3472885e-60bf-4300-9d7a-e5690d53436c
GITHUB_TRIGGERING_ACTOR=rust-cloud-vms[bot]
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/115362/merge
GITHUB_WORKFLOW_SHA=2ff5eb62837dfe3b2cdd2844996a18967575fa68
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
Built container sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Looks like docker image is the same as before, not uploading
https://ci-caches.rust-lang.org/docker/7ebc15c01a233894034d277c8cce4e949f4e7791f66b4727c8fb6e058a0b8171d6152e1441d677cef0653843ceeee469c097b8699b2bb74249e674f6aa1a8813
sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-16]
##[group]Clock drift check
  local time: Mon Dec 18 18:18:18 UTC 2023
  network time: Mon, 18 Dec 2023 18:18:18 GMT
  network time: Mon, 18 Dec 2023 18:18:18 GMT
##[endgroup]
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-16', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-missing-tools', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-16/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: rust.codegen-units-std := 1
---
failures:

---- [ui] tests/ui/closures/issue-112547.rs stdout ----

error: Error: expected failure status (Some(1)) but received status Some(101).
status: exit status: 101
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/closures/issue-112547.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/issue-112547" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/issue-112547/auxiliary"
--- stderr -------------------------------
error[E0412]: cannot find type `V` in this scope
##[error]  --> /checkout/tests/ui/closures/issue-112547.rs:8:4
   |
   |
LL | }> V: IntoIterator
   |
help: you might be missing a type parameter
   |
   |
LL | pub fn bar<V>()

warning: the feature `non_lifetime_binders` is incomplete and may not be safe to use and/or cause compiler crashes
##[warning]  --> /checkout/tests/ui/closures/issue-112547.rs:1:12
   |
   |
LL | #![feature(non_lifetime_binders)]
   |            ^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
   = note: `#[warn(incomplete_features)]` on by default

thread 'rustc' panicked at /checkout/compiler/rustc_middle/src/ty/consts.rs:314:9:
escaping vars in ^1_0: usize
   0:     0x7f680e2d445c - <std[a701fd67beeae20a]::sys_common::backtrace::_print::DisplayBacktrace as core[8f77ad78933f5b0]::fmt::Display>::fmt
   1:     0x7f680e32feff - core[8f77ad78933f5b0]::fmt::write
   1:     0x7f680e32feff - core[8f77ad78933f5b0]::fmt::write
   2:     0x7f680e2c8dc5 - <std[a701fd67beeae20a]::sys::unix::stdio::Stderr as std[a701fd67beeae20a]::io::Write>::write_fmt
   3:     0x7f680e2d4245 - std[a701fd67beeae20a]::sys_common::backtrace::print
   4:     0x7f680e2d756a - std[a701fd67beeae20a]::panicking::default_hook::{closure#1}
   5:     0x7f680e2d726c - std[a701fd67beeae20a]::panicking::default_hook
   6:     0x7f680efb4c67 - <alloc[4bec3a1e5e3a6e62]::boxed::Box<rustc_driver_impl[d07c2998bb954817]::install_ice_hook::{closure#0}> as core[8f77ad78933f5b0]::ops::function::Fn<(&dyn for<'a, 'b> core[8f77ad78933f5b0]::ops::function::Fn<(&'a core[8f77ad78933f5b0]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[8f77ad78933f5b0]::marker::Send + core[8f77ad78933f5b0]::marker::Sync, &core[8f77ad78933f5b0]::panic::panic_info::PanicInfo)>>::call
   7:     0x7f680e2d7bf4 - std[a701fd67beeae20a]::panicking::rust_panic_with_hook
   8:     0x7f680e2d797c - std[a701fd67beeae20a]::panicking::begin_panic_handler::{closure#0}
   9:     0x7f680e2d49f6 - std[a701fd67beeae20a]::sys_common::backtrace::__rust_end_short_backtrace::<std[a701fd67beeae20a]::panicking::begin_panic_handler::{closure#0}, !>
  11:     0x7f680e28e935 - core[8f77ad78933f5b0]::panicking::panic_fmt
  12:     0x7f68112e5fe6 - <rustc_middle[de8279fd9071b141]::ty::consts::Const>::normalize
  12:     0x7f68112e5fe6 - <rustc_middle[de8279fd9071b141]::ty::consts::Const>::normalize
  13:     0x7f68110d5708 - <(rustc_type_ir[39aeed764afbb68e]::predicate_kind::PredicateKind<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>, &rustc_middle[de8279fd9071b141]::ty::list::List<rustc_middle[de8279fd9071b141]::ty::Clause>) as rustc_type_ir[39aeed764afbb68e]::fold::TypeFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::try_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  14:     0x7f68112cfa27 - <rustc_middle[de8279fd9071b141]::ty::sty::Binder<rustc_type_ir[39aeed764afbb68e]::predicate_kind::PredicateKind<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>> as rustc_type_ir[39aeed764afbb68e]::fold::TypeSuperFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::super_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  15:     0x7f68110dd67b - <rustc_middle[de8279fd9071b141]::ty::Predicate as rustc_type_ir[39aeed764afbb68e]::fold::TypeSuperFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::super_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  16:     0x7f68110a799f - <&mut core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>> as core[8f77ad78933f5b0]::iter::traits::iterator::Iterator>::try_fold::<(), <core[8f77ad78933f5b0]::iter::adapters::enumerate::Enumerate<_> as core[8f77ad78933f5b0]::iter::traits::iterator::Iterator>::try_fold::enumerate<rustc_middle[de8279fd9071b141]::ty::Clause, (), core[8f77ad78933f5b0]::ops::control_flow::ControlFlow<(usize, core[8f77ad78933f5b0]::result::Result<rustc_middle[de8279fd9071b141]::ty::Clause, !>)>, core[8f77ad78933f5b0]::iter::traits::iterator::Iterator::find_map::check<(usize, rustc_middle[de8279fd9071b141]::ty::Clause), (usize, core[8f77ad78933f5b0]::result::Result<rustc_middle[de8279fd9071b141]::ty::Clause, !>), rustc_middle[de8279fd9071b141]::ty::util::fold_list<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer, rustc_middle[de8279fd9071b141]::ty::Clause, <&rustc_middle[de8279fd9071b141]::ty::list::List<rustc_middle[de8279fd9071b141]::ty::Clause> as rustc_type_ir[39aeed764afbb68e]::fold::TypeFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::try_fold_with<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>::{closure#0}>::{closure#0}>::{closure#0}>::{closure#0}, core[8f77ad78933f5b0]::ops::control_flow::ControlFlow<(usize, core[8f77ad78933f5b0]::result::Result<rustc_middle[de8279fd9071b141]::ty::Clause, !>)>>
  17:     0x7f6811294a6b - <&rustc_middle[de8279fd9071b141]::ty::list::List<rustc_middle[de8279fd9071b141]::ty::Clause> as rustc_type_ir[39aeed764afbb68e]::fold::TypeFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::try_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  18:     0x7f68110d57b2 - <(rustc_type_ir[39aeed764afbb68e]::predicate_kind::PredicateKind<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>, &rustc_middle[de8279fd9071b141]::ty::list::List<rustc_middle[de8279fd9071b141]::ty::Clause>) as rustc_type_ir[39aeed764afbb68e]::fold::TypeFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::try_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  19:     0x7f68112cfa27 - <rustc_middle[de8279fd9071b141]::ty::sty::Binder<rustc_type_ir[39aeed764afbb68e]::predicate_kind::PredicateKind<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>> as rustc_type_ir[39aeed764afbb68e]::fold::TypeSuperFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::super_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  20:     0x7f68110dd67b - <rustc_middle[de8279fd9071b141]::ty::Predicate as rustc_type_ir[39aeed764afbb68e]::fold::TypeSuperFoldable<rustc_middle[de8279fd9071b141]::ty::context::TyCtxt>>::super_fold_with::<rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}::ConstNormalizer>
  21:     0x7f68110aca28 - <core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>> as core[8f77ad78933f5b0]::iter::traits::iterator::Iterator>::try_fold::<(), core[8f77ad78933f5b0]::iter::adapters::map::map_try_fold<rustc_middle[de8279fd9071b141]::ty::Clause, rustc_middle[de8279fd9071b141]::ty::Clause, (), core[8f77ad78933f5b0]::ops::control_flow::ControlFlow<rustc_middle[de8279fd9071b141]::ty::Clause>, rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}, core[8f77ad78933f5b0]::iter::traits::iterator::Iterator::find::check<rustc_middle[de8279fd9071b141]::ty::Clause, &mut <rustc_infer[d20cad83c59a2992]::traits::util::Elaborator<rustc_middle[de8279fd9071b141]::ty::Clause>>::extend_deduped<core[8f77ad78933f5b0]::iter::adapters::map::Map<core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>>, rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}>>::{closure#0}>::{closure#0}>::{closure#0}, core[8f77ad78933f5b0]::ops::control_flow::ControlFlow<rustc_middle[de8279fd9071b141]::ty::Clause>>
  22:     0x7f6811384f6d - <alloc[4bec3a1e5e3a6e62]::vec::Vec<rustc_middle[de8279fd9071b141]::ty::Clause> as alloc[4bec3a1e5e3a6e62]::vec::spec_extend::SpecExtend<rustc_middle[de8279fd9071b141]::ty::Clause, core[8f77ad78933f5b0]::iter::adapters::filter::Filter<core[8f77ad78933f5b0]::iter::adapters::map::Map<core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>>, rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}>, <rustc_infer[d20cad83c59a2992]::traits::util::Elaborator<rustc_middle[de8279fd9071b141]::ty::Clause>>::extend_deduped<core[8f77ad78933f5b0]::iter::adapters::map::Map<core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>>, rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}>>::{closure#0}>>>::spec_extend
  23:     0x7f68110a23a7 - rustc_infer[d20cad83c59a2992]::traits::util::elaborate::<rustc_middle[de8279fd9071b141]::ty::Clause, core[8f77ad78933f5b0]::iter::adapters::map::Map<core[8f77ad78933f5b0]::iter::adapters::copied::Copied<core[8f77ad78933f5b0]::slice::iter::Iter<rustc_middle[de8279fd9071b141]::ty::Clause>>, rustc_trait_selection[f5ebbbe46c851fdb]::traits::normalize_param_env_or_error::{closure#0}>>
  25:     0x7f680f57fd4d - rustc_ty_utils[7a7ad1a09804017b]::ty::param_env

bors · 2023-12-18T19:44:00Z

☀️ Try build successful - checks-actions
Build commit: fc9bfc9 (fc9bfc929cc887ed990f710b53194d68c37697d7)

rust-timer · 2023-12-18T21:19:42Z

Finished benchmarking commit (fc9bfc9): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.1%, 2.4%]	116
Regressions ❌ (secondary)	1.3%	[0.1%, 3.8%]	79
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	0.8%	[0.1%, 2.4%]	116

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.7%, 1.6%]	9
Regressions ❌ (secondary)	3.0%	[1.5%, 5.1%]	3
Improvements ✅ (primary)	-1.2%	[-2.0%, -0.7%]	3
Improvements ✅ (secondary)	-2.9%	[-5.7%, -0.9%]	7
All ❌✅ (primary)	0.4%	[-2.0%, 1.6%]	12

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.4%, 1.7%]	9
Regressions ❌ (secondary)	2.1%	[1.7%, 2.7%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.4%, 1.7%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.256s -> 682.831s (1.42%)
Artifact size: 312.47 MiB -> 313.05 MiB (0.19%)

Dylan-DPC · 2024-02-14T14:16:27Z

Closing this as it was inactive for a while and has bitrotted with a ton of conflicts plus the perf regression. Might be better starting fresh.

Dylan-DPC · 2024-02-14T14:20:14Z

ah oops then :P fair

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 29, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 29, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2023

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from 3471faa to c915474 Compare September 4, 2023 16:46

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from c915474 to 53c5310 Compare October 17, 2023 23:54

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from 53c5310 to cbe1bbd Compare October 18, 2023 00:06

This comment has been minimized.

Sign in to view

fmease mentioned this pull request Dec 18, 2023

non_lifetime_binders falsely recognizes (and rejects) trait as lifetime #119067

Closed

compiler-errors added 5 commits December 18, 2023 15:53

Allow bounds on non-lifetime binders

24c6468

More non-lifetime binder stuff

aa6737a

Binders have predicates now

9fd4a82

Handle binder predicates in new trait solver

9ba1590

Support trait predicates on poly trait refs

a64db44

More work

82ae54c

rust-cloud-vms bot force-pushed the non-lifetime-binder-where-clauses branch from cbe1bbd to 82ae54c Compare December 18, 2023 17:55

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023

Auto merge of rust-lang#115362 - compiler-errors:non-lifetime-binder-…

2e849e3

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

This comment has been minimized.

Sign in to view

uwu

335a142

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023

Auto merge of rust-lang#115362 - compiler-errors:non-lifetime-binder-…

fc9bfc9

…where-clauses, r=<try> [WIP] Support param bounds on non-lifetime binders 👀 r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 18, 2023

Dylan-DPC closed this Feb 14, 2024

compiler-errors reopened this Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Support param bounds on non-lifetime binders #115362

[WIP] Support param bounds on non-lifetime binders #115362

compiler-errors commented Aug 29, 2023

compiler-errors commented Aug 29, 2023

bors commented Aug 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Aug 29, 2023

bors commented Sep 3, 2023

This comment has been minimized.

bors commented Sep 14, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Oct 18, 2023

fmease commented Oct 19, 2023 •

edited

Loading

compiler-errors commented Oct 19, 2023 •

edited

Loading

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Dec 18, 2023

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

rust-log-analyzer commented Dec 18, 2023

bors commented Dec 18, 2023

This comment has been minimized.

rust-timer commented Dec 18, 2023

Dylan-DPC commented Feb 14, 2024

Dylan-DPC commented Feb 14, 2024

[WIP] Support param bounds on non-lifetime binders #115362

Are you sure you want to change the base?

[WIP] Support param bounds on non-lifetime binders #115362

Conversation

compiler-errors commented Aug 29, 2023

compiler-errors commented Aug 29, 2023

bors commented Aug 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Aug 29, 2023

bors commented Sep 3, 2023

This comment has been minimized.

bors commented Sep 14, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Oct 18, 2023

fmease commented Oct 19, 2023 • edited Loading

compiler-errors commented Oct 19, 2023 • edited Loading

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Dec 18, 2023

compiler-errors commented Dec 18, 2023

This comment has been minimized.

bors commented Dec 18, 2023

rust-log-analyzer commented Dec 18, 2023

bors commented Dec 18, 2023

This comment has been minimized.

rust-timer commented Dec 18, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Dylan-DPC commented Feb 14, 2024

Dylan-DPC commented Feb 14, 2024

fmease commented Oct 19, 2023 •

edited

Loading

compiler-errors commented Oct 19, 2023 •

edited

Loading