Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry download of rustc-perf in opt-dist #115543

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Sep 4, 2023

This should help resolving spurious network errors. It also increases the timeout for the archive download.

r? @Mark-Simulacrum

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2023
@Mark-Simulacrum
Copy link
Member

r=me after a rebase (post #115541)

src/tools/opt-dist/src/utils/mod.rs Outdated Show resolved Hide resolved
src/tools/opt-dist/src/utils/mod.rs Show resolved Hide resolved
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2023

Thanks @Kobzol for the fast response!

This should help resolving spurious network errors. It also increases the timeout for the archive download.
@Kobzol
Copy link
Contributor Author

Kobzol commented Sep 4, 2023

Rebased on top of (merged) #115541.

@bors r=@Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 4, 2023

📌 Commit c98455f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 4, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@bors
Copy link
Contributor

bors commented Sep 4, 2023

⌛ Testing commit c98455f with merge 7fd3a858b5be429bffef75ac8bdddca5ce2bb100...

@bors
Copy link
Contributor

bors commented Sep 4, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2023
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2023

@bors retry

GitHub checkout failed

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
##[error]Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_d05f9ad2-6f88-4d88-aade-dc1ba68acefe/3643c3b2-f351-450a-b35d-017302152f50.tar.gz. return code: 2.

@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit c98455f with merge e3bdb6e8cfef46224bd3035f27c97e8cab4d6bcd...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
##[error]Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_496a29d7-364d-45c1-a1b5-8ccec3b67f20/dfc1eb3f-ed0d-4dff-8ab4-a46049f56ad6.tar.gz. return code: 2.

@ehuss
Copy link
Contributor

ehuss commented Sep 5, 2023

@bors retry

GitHub checkout issue

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2023
@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit c98455f with merge 15e52b0...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 15e52b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2023
@bors bors merged commit 15e52b0 into rust-lang:master Sep 5, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 5, 2023
@Kobzol Kobzol deleted the opt-dist-retry-download branch September 5, 2023 09:08
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15e52b0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 2
Improvements ✅
(primary)
-1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)
-2.7% [-3.4%, -1.9%] 2
All ❌✅ (primary) -1.7% [-1.7%, -1.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.68s -> 627.647s (-0.16%)
Artifact size: 316.31 MiB -> 316.22 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants