Make AIX known by bootstrap #115811
Merged
Make AIX known by bootstrap #115811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Sep 13, 2023
| @@ -312,6 +312,8 @@ def default_build_triple(verbose): | |||
| # non-standard string (e.g. gnuwin32 tools returns `windows32`). In | |||
| # these cases, fall back to using sys.platform. | |||
| return 'x86_64-pc-windows-msvc' | |||
| elif kernel == 'AIX': | |||
There was a problem hiding this comment.
Would it make more sense to add AIX to the kerneltype map above?
There was a problem hiding this comment.
I've added comment to describe the reason :).
|
@rustbot ready. |
|
r? bootstrap |
|
Flipping back to the original assignee... |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 18, 2023
…crum Make AIX known by bootstrap Use `x.py` to build rustc on AIX directly is failing ``` unknown OS type: AIX Build completed unsuccessfully in 0:00:00 ``` If kernel is `AIX`, we should return default triple `powerpc64-ibm-aix` for current rustc.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115795 (Refactor `opt-dist` to simplify local building) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115908 (Do not clone MIR for const-prop lint.) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
Rollup merge of rust-lang#115811 - bzEq:make-aix-known, r=Mark-Simulacrum Make AIX known by bootstrap Use `x.py` to build rustc on AIX directly is failing ``` unknown OS type: AIX Build completed unsuccessfully in 0:00:00 ``` If kernel is `AIX`, we should return default triple `powerpc64-ibm-aix` for current rustc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
x.pyto build rustc on AIX directly is failingIf kernel is
AIX, we should return default triplepowerpc64-ibm-aixfor current rustc.