Canonicalize effect vars in new solver #115850
Conversation
rustbot
added
S-waiting-on-review
| @@ -382,6 +382,17 @@ impl<'tcx> TypeFolder<TyCtxt<'tcx>> for EagerResolver<'_, 'tcx> { | |||
| } | |||
| } | |||
| } | |||
| ty::ConstKind::Infer(ty::InferConst::EffectVar(vid)) => { | |||
| // FIXME: we need to fold the ty too, I think. | |||
There was a problem hiding this comment.
The effect variable always has type bool so we should be able to just use that here.
There was a problem hiding this comment.
Oh right, I can remove this fixme. It was just copy paste error.
rust-cloud-vms
bot
force-pushed
the
effect-canon
branch
from
63f31e2 to
280f058
Compare
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (915c8af): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.716s -> 631.608s (-0.02%) |
No good reason not to fix this, we already have all the machinery to make this work.
r? @fee1-dead
Fixes #115792