-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore #[doc(hidden)]
functions in clippy doc lints
#115851
Conversation
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Why is this filed on |
#115689 isn't in rust-clippy yet |
+1 Fuchsia ran into this |
@bors r+ rollup Thanks! |
☀️ Test successful - checks-actions |
Finished benchmarking commit (56e1aaa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.608s -> 631.442s (-0.03%) |
… r=flip1995 Ignore `#[doc(hidden)]` functions in clippy doc lints Fixes rust-lang/rust-clippy#11501 The implementation before rust-lang#115689 had a check for unsugared doc comments that also happened to catch `#[doc(hidden)]`, this adds the check back in more explicitly https://github.com/rust-lang/rust/blob/852bf4e51bf260550cd1a280d2146f1c0641b1e8/src/tools/clippy/clippy_lints/src/doc.rs#L526-L529 r? `@flip1995`
Fixes rust-lang/rust-clippy#11501
The implementation before #115689 had a check for unsugared doc comments that also happened to catch
#[doc(hidden)]
, this adds the check back in more explicitlyrust/src/tools/clippy/clippy_lints/src/doc.rs
Lines 526 to 529 in 852bf4e
r? @flip1995