Don't complain on a single non-exhaustive 1-ZST #115924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Sep 18, 2023
RalfJung
reviewed
Sep 18, 2023
Comment on lines
+136
to
+140
| error: zero-sized fields in `repr(transparent)` cannot contain external non-exhaustive types | ||
| --> $DIR/repr-transparent-non-exhaustive.rs:102:31 | ||
| | | ||
| LL | pub struct T18(NonExhaustive, NonExhaustive); | ||
| | ^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Seems fine to land this for now to fix the regression, but could you file a diagnostics issue about this? The error says "zero-sized fields [...] cannot contain external non-exhaustive types" but that's not really accurate, some zero-sized fields can in fact contain such non-exhaustive types.
compiler-errors
force-pushed
the
non-exhaustive-1-zst
branch
from
54c33d3
to
537834d
Compare
RalfJung
reviewed
Sep 19, 2023
| // Okay, since there's only 1 foreign non-exhaustive type. | ||
|
|
||
| #[repr(transparent)] | ||
| pub struct T22Flipped(NonExhaustive, InternalPrivate); |
There was a problem hiding this comment.
Copy paste issue 🤦
Should I just give these structs better names while we're at it? Like, the whole file?
There was a problem hiding this comment.
If you have good naming ideas, sure, why not.
There was a problem hiding this comment.
Nothing comes to mind actually that isn't incredibly verbose. 😓
|
r=me after fixing the test |
rust-cloud-vms
bot
force-pushed
the
non-exhaustive-1-zst
branch
from
537834d
to
fd36553
Compare
|
@bors r=RalfJung |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#112725 (rustdoc-search: add support for type parameters) - rust-lang#114941 (Don't resolve generic impls that may be shadowed by dyn built-in impls) - rust-lang#115625 (Explain HRTB + infer limitations of old solver) - rust-lang#115839 (Bump libc to 0.2.148) - rust-lang#115924 (Don't complain on a single non-exhaustive 1-ZST) - rust-lang#115946 (panic when encountering an illegal cpumask in thread::available_parallelism) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2023
Rollup merge of rust-lang#115924 - compiler-errors:non-exhaustive-1-zst, r=RalfJung Don't complain on a single non-exhaustive 1-ZST r? RalfJung, though you mentioned being busy, so feel free to reassign. This doesn't actually attempt to make the diagnostic better, so when we have two non-exhaustive 1-ZSTs in a struct, we still just point to one. 🤷 Fixes rust-lang#115922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? RalfJung, though you mentioned being busy, so feel free to reassign.
This doesn't actually attempt to make the diagnostic better, so when we have two non-exhaustive 1-ZSTs in a struct, we still just point to one. 🤷
Fixes #115922