-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: reduce the amount of crates pulling in atty #115975
Conversation
CC: @stlankes |
(rustbot has picked a reviewer for you, use r? to override) |
The Miri subtree was changed cc @rust-lang/miri These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
This reduces the amount of dependencies pulling in atty. ``` Updating colored v2.0.0 -> v2.0.4 Updating tracing-tree v0.2.3 -> v0.2.4 ``` Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
This reduces the amount of dependencies pulling in atty. ``` Removing env_logger v0.9.3 ``` Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
1371878
to
7928c7e
Compare
Third-party dependency whitelist may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
The Miri subtree was changed cc @rust-lang/miri |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e3811a7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.97s -> 632.207s (0.20%) |
It would be nice to have only one
hermit-abi
inCargo.lock
(#107405 (comment)).The only crate pulling in the old
hermit-abi
version isatty
, which is unmaintained.This PR upgrades three dependencies, which then no longer depend on
atty
:Cargo.lock
:colored v2.0.0 -> v2.0.4
Cargo.lock
:tracing-tree v0.2.3 -> v0.2.4
env_logger 0.9.3 -> 0.10.0
The only dependency chain left that pulls in
hermit-abi 0.1.19
is:hermit-abi 0.1.19
->atty 0.2.14
->env_logger 0.7.1
->jsonpath_lib 0.2.6
->jsondocck 0.1.0
(src/tools/jsondocck)Replacing jsondocck with jsondocckng is tracked in #94140.