Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_target/loongarch: Fix passing of transparent unions with only one non-ZST member #115987

Merged
merged 2 commits into from
Sep 20, 2023
Merged

rustc_target/loongarch: Fix passing of transparent unions with only one non-ZST member #115987

merged 2 commits into from
Sep 20, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Sep 20, 2023

This ensures that MaybeUninit<T> has the same ABI as T when passed through an extern "C" function.

Fixes #115509

r? @bjorn3

…ne non-ZST member

This ensures that `MaybeUninit<T>` has the same ABI as `T` when passed
through an `extern "C"` function.

Fixes #115509
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2023
@bjorn3
Copy link
Member

bjorn3 commented Sep 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 20, 2023

📌 Commit 10d55c3 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@bors
Copy link
Contributor

bors commented Sep 20, 2023

⌛ Testing commit 10d55c3 with merge ad36b5a...

@bors
Copy link
Contributor

bors commented Sep 20, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing ad36b5a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2023
@bors bors merged commit ad36b5a into rust-lang:master Sep 20, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ad36b5a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.0% [5.0%, 5.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-3.2%, -1.3%] 3
All ❌✅ (primary) 5.0% [5.0%, 5.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.382s -> 632.887s (-0.08%)
Artifact size: 317.82 MiB -> 317.80 MiB (-0.00%)

@RalfJung
Copy link
Member

RalfJung commented Sep 21, 2023

This should really share code with the riscv ABI, having this all implemented twice is a pain. The ABIs are 100% identical, at least in their current Rust implementation.

@heiher heiher deleted the fix-transparent-union-abi branch September 26, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loongarch64-unknown-linux-gnu extern "C" ABI violates repr(transparent) on unions
6 participants