Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #116111

Closed
wants to merge 13 commits into from
Closed

Rollup of 5 pull requests #116111

wants to merge 13 commits into from

Commits on Sep 22, 2023

  1. Allow higher-ranked fn sigs in ValuePairs

    @compiler-errors
    compiler-errors committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8cfd249 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Tweak expected message to explain what it's actually signifying

    @compiler-errors
    compiler-errors committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    82e7cec View commit details
    Browse the repository at this point in the history

  2. More accurate suggestion for self. and Self:: 

    Fix rust-lang#115992.
    @estebank
    estebank committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c4a4926 View commit details
    Browse the repository at this point in the history

  3. When encountering method on Self that we can't suggest, mention it

    @estebank
    estebank committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0e98682 View commit details
    Browse the repository at this point in the history

  4. Tweak wording and logic

    @estebank
    estebank committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ac5e187 View commit details
    Browse the repository at this point in the history

  5. Add test

    @estebank
    estebank committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7d8559a View commit details
    Browse the repository at this point in the history

  6. Reuse calculate_debuginfo_offset for fragments.

    @cjgillot
    cjgillot committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    8ec5639 View commit details
    Browse the repository at this point in the history

  7. Migrate GUI colors test to original CSS color format

    @GuillaumeGomez
    GuillaumeGomez committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    2d25a25 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#116073 - compiler-errors:poly-sigs, r=b-naber 

    Allow higher-ranked fn sigs in `ValuePairs`

For better bookkeeping -- only affects diagnostic path. Allow reporting signature mismatches like "signature"s and not "fn pointer"s.

Improves rust-lang#115897 (comment)
    @matthiaskrgr
    matthiaskrgr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    d402fbd View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#116082 - compiler-errors:default-assoc-ty-m… 

    …sg, r=estebank

Tweak expected message to explain what it's actually signifying

r? `@estebank` since you added this
    @matthiaskrgr
    matthiaskrgr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ac5646a View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#116086 - estebank:issue-115992, r=compiler-… 

    …errors

More accurate suggestion for `self.` and `Self::`

Detect that we can't suggest `self.` in an associated function without `&self` receiver.

Partially address rust-lang#115992.

r? `@compiler-errors`
    @matthiaskrgr
    matthiaskrgr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0850444 View commit details
    Browse the repository at this point in the history

  11. Rollup merge of rust-lang#116104 - cjgillot:calculate_debuginfo_offse… 

    …t, r=b-naber

Reuse calculate_debuginfo_offset for fragments.

This removes a little code duplication.
    @matthiaskrgr
    matthiaskrgr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    366d546 View commit details
    Browse the repository at this point in the history

  12. Rollup merge of rust-lang#116106 - GuillaumeGomez:migrate-gui-test-co… 

    …lor-42, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

And with this one I'm finally done with this migration.

r? `@notriddle`
    @matthiaskrgr
    matthiaskrgr committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    37f1d69 View commit details
    Browse the repository at this point in the history