Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #116492

Merged
merged 25 commits into from
Oct 6, 2023
Merged

Rollup of 7 pull requests #116492

merged 25 commits into from
Oct 6, 2023

Commits on Sep 30, 2023

  1. Configuration menu
    Copy the full SHA
    13e5875 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Fix typo in attrs.rs

    documenation -> documentation
    eltociear committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    23efab4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    80bf688 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4091936 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Remove map_layouts.

    As per the `FIXME` comment, it's an abstraction that makes the code
    harder to read.
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    449b84c View commit details
    Browse the repository at this point in the history
  2. Fix a comment.

    It was duplicated from the method above.
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    73420fc View commit details
    Browse the repository at this point in the history
  3. Remove the MaybeTransmutableQuery<&'l Dfa<...>, C> impl.

    Because there is also a `MaybeTransmutableQuery<Dfa<...>, C>` impl, and
    we don't need both.
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    29ed8e4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    442a66d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    108e541 View commit details
    Browse the repository at this point in the history
  6. Factor out insert_or_error.

    It appears identically as a closure in two functions.
    
    Also change its return type from `bool` to `Option<()>` so it can be
    used with `?`.
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e49a147 View commit details
    Browse the repository at this point in the history
  7. Remove unneeded dependency.

    Also sort them.
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4b51a3e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    093b435 View commit details
    Browse the repository at this point in the history
  9. Remove unnecessary pub.

    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e7dabc9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b80e653 View commit details
    Browse the repository at this point in the history
  11. Don't mention "recover the original" in From docs

    Co-authored-by: Josh Triplett <josh@joshtriplett.org>
    scottmcm and joshtriplett committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    44f92c1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1651f1f View commit details
    Browse the repository at this point in the history
  13. Reuse existing Somes in Option::(x)or

    LLVM still has trouble re-using discriminants sometimes when rebuilding a two-variant enum, so when we have the correct variant already built, just use it.
    
    That's simpler in LLVM *and* in MIR, so might as well: <https://rust.godbolt.org/z/KhdE8eToW>
    scottmcm committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5432d13 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    c95015c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#114564 - scottmcm:when-to-from, r=dtolnay

    Attempt to describe the intent behind the `From` trait further
    
    Inspired by the <https://internals.rust-lang.org/t/allow-use-as-and-try-as-for-from-and-tryfrom-traits/19240/26?u=scottmcm> thread.
    
    `@rustbot` label +T-libs-api
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4dfa5e5 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#116297 - RalfJung:hooks, r=oli-obk

    add some docs to hooks/mod.rs
    
    r? `@oli-obk`
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    fdb136a View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#116423 - eltociear:patch-22, r=flip1995

    Fix typo in attrs.rs
    
    documenation -> documentation
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    81192f2 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#116466 - nnethercote:rustc_transmute, r=oli…

    …-obk
    
    `rustc_transmute` cleanups
    
    Just some things I found while poking around this code.
    
    r? `@oli-obk`
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    25fbd13 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#116474 - nnethercote:rustc_assorted, r=spas…

    …torino
    
    Assorted small cleanups
    
    r? `@spastorino`
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9796dfd View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#116481 - scottmcm:tweak-combinators, r=cuviper

    Reuse existing `Some`s in `Option::(x)or`
    
    LLVM still has trouble re-using discriminants sometimes when rebuilding a two-variant enum, so when we have the correct variant already built, just use it.
    
    That's shorter in the Rust code, as well as simpler in MIR and the optimized LLVM, so might as well: <https://rust.godbolt.org/z/KhdE8eToW>
    
    Thanks to `@veber-alex` for pointing out this opportunity in rust-lang#101210 (comment)
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f8dae0c View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#116484 - peterjoel:once-doc-clarify, r=cuviper

    Minor doc clarification in Once::call_once
    matthiaskrgr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7f0cf8c View commit details
    Browse the repository at this point in the history