Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustc_onunimplemented export path agnostic #116805

Commits on Oct 16, 2023

  1. Make rustc_onunimplemented export path agnostic

    This makes it so that all the matchers that match against paths use the
    definition path instead of the export path. This removes all duplication
    around `std`/`alloc`/`core`.
    
    This is not necessarily optimal because we now depend on internal
    implementation details like `core::ops::control_flow::ControlFlow`,
    which is not very nice and probably not acceptable for a stable
    `on_unimplemented`.
    
    An alternative would be to just string-replace normalize away
    `alloc`/`core` to `std` as a special case, keeping the export paths but
    making it so that we're still fully standard library flavor agnostic.
    Noratrieb committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    414135d View commit details
    Browse the repository at this point in the history