Uplift generator movability to rustc_type_ir

[compiler-errors]

Part of rust-lang/types-team#124

r? types

[rustbot]

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[oli-obk]

Can we somehow keep sharing the hir and ir Movability type? Or is there no existing crate dependency from rustc_hir to rustc_ir?

[RalfJung]

Why are there two of these PRs...? This an #116919.

[compiler-errors]

@RalfJung because they're different types and are pretty different review sizes.

This PR touches 19 files, mostly within the compiler. That PR touches 124 files which span across the compiler, codegen backends, clippy, miri, etc.

[compiler-errors]

@oli-obk: No, there are no crate deps between them that would make sense to put this type in.

[RalfJung]

Oh, movability != mutability. 🤦

[oli-obk]

@oli-obk: No, there are no crate deps between them that would make sense to put this type in.

If this becomes more common, maybe we should create such a crate. We merged some of these types to avoid any conversions or import confusions

[bors]

☔ The latest upstream changes (presumably #116923) made this pull request unmergeable. Please resolve the merge conflicts.

[lcnr]

It feels like creating a new rustc_ir_core or whatever for Mutability would significantly help with #116919 🤔 so I would prefer this over having duplicate types.

THough alternatively, can rustc_hir just depend on rustc_type_ir? This feels like the easiest solution here? 🤔