When not finding assoc fn on type, look for builder fn

[estebank]

When we have a resolution error when looking at a fully qualified path on a type, look for all associated functions on inherent impls that return Self and mention them to the user.

error[E0599]: no function or associated item named `new` found for struct `TcpStream` in the current scope
   --> tests/ui/resolve/fn-new-doesnt-exist.rs:4:28
    |
4   |    let stream = TcpStream::new();
    |                            ^^^ function or associated item not found in `TcpStream`
    |
note: if you're trying to build a new `TcpStream` consider using one of the following associated functions:
      TcpStream::connect
      TcpStream::connect_timeout
   --> /home/gh-estebank/rust/library/std/src/net/tcp.rs:156:5
    |
156 |     pub fn connect<A: ToSocketAddrs>(addr: A) -> io::Result<TcpStream> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
172 |     pub fn connect_timeout(addr: &SocketAddr, timeout: Duration) -> io::Result<TcpStream> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Fix #69512.

[rustbot]

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

[davidtwco]

Sorry for the delay in getting to this, will re-assign to compiler-errors since they've left a review already.

r? @compiler-errors

[compiler-errors]

r=me after addressing

[compiler-errors]

please pull this out into a method. Also, can you use a let-chain here instead of destructuring a tuple?

[estebank]

I tend to use tuple destructuring in favor of let-chains when I want to make sure rustfmt works, particularly in long blocks. I can change it, of course. I personally like let-chains more.

[estebank]

@bors r=compiler-errors

[bors]

📌 Commit f926031 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit f926031 with merge 4e0fb98...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4e0fb98 to master...

[rust-timer]

Finished benchmarking commit (4e0fb98): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	1.6%	[1.2%, 3.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.9%, -2.6%]	2
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[1.9%, 3.2%]	3
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.8%, -0.5%]	2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 662.627s -> 663.851s (0.18%)
Artifact size: 308.96 MiB -> 309.01 MiB (0.02%)