Update cargo

[weihanglo]

7 commits in 708383d620e183a9ece69b8fe930c411d83dee27..b4d18d4bd3db6d872892f6c87c51a02999b80802
2023-10-27 21:09:26 +0000 to 2023-10-31 18:19:10 +0000

• refactor(toml): Cleanup noticed on the way to Official API for parsing Cargo.tomls schema cargo#12801 (refactor(toml): Cleanup noticed on the way to #12801 cargo#12902)
• feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts (feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts cargo#12900)
• feat: implement RFC 3127 -Ztrim-paths (feat: implement RFC 3127 -Ztrim-paths cargo#12625)
• docs: clarify config to use vendored source is printed to stdout (docs: clarify config to use vendored source is printed to stdout cargo#12893)
• Improve the margin calculation for the search command's UI (Improve the margin calculation for the search command's UI cargo#12890)
• Add new packages to [workspace.members] automatically (Add new packages to [workspace.members] automatically cargo#12779)
• refactor(toml): Decouple parsing from interning system (refactor(toml): Decouple parsing from interning system cargo#12881)

r? ghost

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[weihanglo]

@bors r+ p=1 rollup=never

[bors]

📌 Commit 7ea6977 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7ea6977 with merge 9d83ac2...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 9d83ac2 to master...

[rust-timer]

Finished benchmarking commit (9d83ac2): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.8%, 1.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.4%]	2
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	0.2%	[-0.6%, 1.1%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	11
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.7%, -0.0%]	10
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	4
All ❌✅ (primary)	-0.0%	[-0.7%, 0.3%]	21

Bootstrap: 638.947s -> 638.452s (-0.08%)
Artifact size: 304.48 MiB -> 304.50 MiB (0.01%)

[weihanglo]

rust-lang/cargo#12881 might be related?

cc @epage, though I think it is just marginal and no action needed.

[pnkfelix]

• regressions are to unicode-normalization-opt-incr-patched:println (1.06%) and clap-opt-full (0.81%)
• the regressions to instruction counts seem small but they persist; i.e. this is not transient noise. (It is not clear whether the cost is borne from cargo itself, or if something has changed about how cargo is invoking rustc that incurs this cost.)
• on the other hand, cycle counts and wall time are not impacted at all, which implies to me that this is probably not worth investigating.
• marking as triaged.

@rustbot label: +perf-regression-triaged

[weihanglo]

will look into it

[nnethercote]

(It is not clear whether the cost is borne from cargo itself, or if something has changed about how cargo is invoking rustc that incurs this cost.)

The benchmarks measure the time rustc/rustdoc takes to compile a single crate. Cargo's execution time isn't measured. So "cargo itself" should be impossible as an explanation. "How cargo is invoking rustc" is possible.

[weihanglo]

The only thing touches rustc invocation is rust-lang/cargo#12625, but it is behind a cargo feature flag -Ztrim-paths so shouldn't affect anything IMO.