-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add richer structure for Stable MIR Projections #117517
Merged
Merged
Commits on Nov 10, 2023
-
Add stable MIR Projections support based on MIR structure
This commit includes richer projections for both Places and UserTypeProjections. However, the tests only touch on Places. There are also outstanding TODOs regarding how projections should be resolved to produce Place types, and regarding if UserTypeProjections should just contain ProjectionElem<(),()> objects as in MIR.
Configuration menu - View commit details
-
Copy full SHA for b158598 - Browse repository at this point
Copy the full SHA b158598View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98228e6 - Browse repository at this point
Copy the full SHA 98228e6View commit details -
Replace match assertions against empty slices with is_empty assertions
Asserting is_empty is slightly more concise.
Configuration menu - View commit details
-
Copy full SHA for 30d6733 - Browse repository at this point
Copy the full SHA 30d6733View commit details -
Remove rich UserTypeProjection projections in SMIR
It's not clear to me (klinvill) that UserTypeProjections are produced anymore with the removal of type ascriptions as per rust-lang/rfcs#3307. Furthermore, it's not clear to me which variants of ProjectionElem could appear in such projections. For these reasons, I'm reverting projections in UserTypeProjections to simple strings until I can get more clarity on UserTypeProjections.
Configuration menu - View commit details
-
Copy full SHA for 2e70d95 - Browse repository at this point
Copy the full SHA 2e70d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998aa38 - Browse repository at this point
Copy the full SHA 998aa38View commit details -
Configuration menu - View commit details
-
Copy full SHA for d517a1c - Browse repository at this point
Copy the full SHA d517a1cView commit details
Commits on Nov 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ae1726b - Browse repository at this point
Copy the full SHA ae1726bView commit details
Commits on Nov 15, 2023
-
Make UserTypeProjection projections Opaque
Also shifts comments explaining why Stable MIR drops an optional variant name field, for `Downcast` projection elements, to the `Place::stable` function.
Configuration menu - View commit details
-
Copy full SHA for c036a10 - Browse repository at this point
Copy the full SHA c036a10View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.