Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] backports #117644

Merged
merged 4 commits into from
Nov 7, 2023
Merged

[beta] backports #117644

merged 4 commits into from
Nov 7, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 6, 2023

r? cuviper

onur-ozkan and others added 4 commits November 6, 2023 13:07
Signed-off-by: onur-ozkan <work@onurozkan.dev>
(cherry picked from commit 2c8759e)
(cherry picked from commit 0b96e47)
Fix: Write access check of `prefix` and `sysconfdir`
when DESTDIR is present.

Improvement: Instead of repeatedly reading `DESTDIR` within
each `fn prepare_dir` usage, read it once and pass it to
the `fn prepare_dir`.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
(cherry picked from commit 4b14048)
(cherry picked from commit 9df857f)
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 6, 2023
@cuviper
Copy link
Member Author

cuviper commented Nov 6, 2023

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Nov 6, 2023

📌 Commit efb81ca has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023
@bors
Copy link
Contributor

bors commented Nov 6, 2023

⌛ Testing commit efb81ca with merge 4a202dc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2023
[beta] backports

- ensure the parent path's existence on `x install` rust-lang#116349
- Remove `cfg_match` from the prelude rust-lang#117162
- improve and fix `x install` rust-lang#117383
- Update to LLVM 17.0.4 rust-lang#117436

r? cuviper
@bors
Copy link
Contributor

bors commented Nov 7, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2023
@cuviper
Copy link
Member Author

cuviper commented Nov 7, 2023

The runner has received a shutdown signal.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2023
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_mir_dataflow test:false 37.046
   Compiling rustc_hir_analysis v0.0.0 (/checkout/compiler/rustc_hir_analysis)
[RUSTC-TIMING] rustc_ast_lowering test:false 48.930
   Compiling rustc_lint v0.0.0 (/checkout/compiler/rustc_lint)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.


Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Contributor

bors commented Nov 7, 2023

⌛ Testing commit efb81ca with merge 4599293...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
[beta] backports

- ensure the parent path's existence on `x install` rust-lang#116349
- Remove `cfg_match` from the prelude rust-lang#117162
- improve and fix `x install` rust-lang#117383
- Update to LLVM 17.0.4 rust-lang#117436

r? cuviper
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Nov 7, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2023
@Mark-Simulacrum
Copy link
Member

@bors retry network issue

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2023
@bors
Copy link
Contributor

bors commented Nov 7, 2023

⌛ Testing commit efb81ca with merge efc300e...

@bors
Copy link
Contributor

bors commented Nov 7, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing efc300e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2023
@bors bors merged commit efc300e into rust-lang:beta Nov 7, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Nov 7, 2023
@cuviper cuviper deleted the beta-next branch November 8, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants