Explicitly implement DynSync and DynSend for TyCtxt

[Zoxc]

This is an attempt to short circuit trait resolution. It should get a perf run for bootstrap impact.

[rustbot]

r? @spastorino

(rustbot has picked a reviewer for you, use r? to override)

[lqd]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b60717f with merge 59b2405...

[bors]

☀️ Try build successful - checks-actions
Build commit: 59b2405 (59b2405e8a536710457f0e9115c9736308c8718d)

[rust-timer]

Finished benchmarking commit (59b2405): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	7
All ❌✅ (primary)	-	-	0

Bootstrap: 663.998s -> 657.62s (-0.96%)
Artifact size: 308.95 MiB -> 308.98 MiB (0.01%)

[compiler-errors]

Did we expect this to be a speed-up? If not, is this still worth landing?

r? compiler-errors @rustbot author

[Zoxc]

I was expecting a bootstrap improvement, which we did see.

[compiler-errors]

Okay then!

@bors r+

[bors]

📌 Commit b60717f has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout tcx-sync (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self tcx-sync --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging compiler/rustc_middle/src/ty/context.rs
CONFLICT (content): Merge conflict in compiler/rustc_middle/src/ty/context.rs
Automatic merge failed; fix conflicts and then commit the result.

[lqd]

@bors r=compiler-errors

[bors]

📌 Commit 54492fe has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 54492fe with merge 9ea6a18...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@rustbot author
@bors delegate+

[bors]

✌️ @Zoxc, you can now approve this pull request!

If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors

[Zoxc]

@bors r=@compiler-errors

[bors]

📌 Commit 365aaa8 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 365aaa8 with merge 2d2f1b2...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 2d2f1b2 to master...

[rust-timer]

Finished benchmarking commit (2d2f1b2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[2.4%, 5.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.7%	[2.4%, 5.0%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.8%	[7.7%, 8.0%]	3
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.179s -> 669.53s (-0.98%)
Artifact size: 314.02 MiB -> 314.04 MiB (0.01%)